[1.20] Set systemd property KillMode to mixed for containers #4539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4539 +/- ##
================================================
+ Coverage 40.60% 40.62% +0.01%
================================================
Files 117 117
Lines 9446 9450 +4
================================================
+ Hits 3836 3839 +3
- Misses 5177 5178 +1
Partials 433 433 |
Member
Author
|
/test integration_fedora |
We want systemd to only send SIGTERM to the main process on stop and let that process forward the signal. Today, we have seen issues where the main process forwards the signal in addition to systemd sending it directly leading to failures in graceful shutdown. Signed-off-by: Mrunal Patel <[email protected]>
f7f6754 to
8164338
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrunal Patel [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR sets the systemd KillMode for container scopes to mixed
so on stop, only the main process gets the SIGTERM and is
responsible for forwarding it if needed to child processes.
Without this, we end up with double SIGTERMS leading to unexpected
failures in graceful termination on node shutdown or reboot.
Which issue(s) this PR fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1882750
Special notes for your reviewer:
Does this PR introduce a user-facing change?