Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove dead code #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Apr 1, 2021
Merged

remove dead code #4678

openshift-merge-robot merged 5 commits into from
Apr 1, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Mar 19, 2021

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

I fell down a rabbit hole...

found using staticcheck:
staticcheck -tags=test --unused.whole-program=true -- ./...
(an old version though go get honnef.co/go/tools/cmd/[email protected])

I did not remove all the dead code. some code we've adapted from other repos, and don't use some fields. I think it's worth keeping them. I have also left some functions that are not used in the code base, but are useful in tests (container_server HasSandbox is an example)

Does this PR introduce a user-facing change?

none

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021 •
edited
Loading

Codecov Report

Merging #4678 (a0e0e75) into master (e6c19d7) will increase coverage by 0.11%.
The diff coverage is 66.66%.

❗ Current head a0e0e75 differs from pull request most recent head b052217. Consider uploading reports for the commit b052217 to get more accurate results

@@            Coverage Diff             @@
##           master    #4678      +/-   ##
==========================================
+ Coverage   41.29%   41.41%   +0.11%     
==========================================
  Files         110      105       -5     
  Lines        9600     9360     -240     
==========================================
- Hits         3964     3876      -88     
+ Misses       5185     5038     -147     
+ Partials      451      446       -5

saschagrunert
saschagrunert approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haircommander
Copy link
Member Author

haircommander commented Mar 22, 2021

/retest

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Mar 22, 2021

LGTM
assuming happy tests.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2021
giuseppe
giuseppe approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp
Copy link
Member

mrunalp commented Apr 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

haircommander commented Apr 1, 2021

/test e2e-agnostic

@haircommander haircommander mentioned this pull request Apr 1, 2021
Merged
@haircommander
Copy link
Member Author

haircommander commented Apr 1, 2021

/override ci/prow/e2e-agnostic
(passed on gcp)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic

Details

In response to this:

/override ci/prow/e2e-agnostic
(passed on gcp)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 b052217 link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

haircommander commented Apr 1, 2021

/override ci/prow/e2e-agnostic

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic

Details

In response to this:

/override ci/prow/e2e-agnostic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cae4839 into cri-o:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@giuseppe giuseppe giuseppe approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @TomSweeneyRedHat @mrunalp @openshift-ci-robot @giuseppe @saschagrunert @openshift-merge-robot