Hi @ityuhui. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Codecov Report

Merging #4682 (e667558) into master (8118d4a) will increase coverage by 1.79%.
The diff coverage is 93.19%.

❗ Current head e667558 differs from pull request most recent head a522712. Consider uploading reports for the commit a522712 to get more accurate results

@@            Coverage Diff             @@
##           master    #4682      +/-   ##
==========================================
+ Coverage   41.32%   43.12%   +1.79%     
==========================================
  Files         107      107              
  Lines        9405     9742     +337     
==========================================
+ Hits         3887     4201     +314     
- Misses       5074     5088      +14     
- Partials      444      453       +9     

WOW this is better than what I was imagining
/ok-to-test

there are some test failures, and I'll have a deeper look at the code, but at a glance this looks great 🎉

error is:

not ok 141 pod pause image matches configured image in crio.conf
# (in test file ./pod.bats, line 249)
#   `conf_pause_image=$(grep -oP 'pause_image = \K"[^"]+"' "$CRIO_CONFIG")' failed

you can run it with
sudo bats test/pod.bats -f "pod pause image"

Hi @haircommander

I have fixed all errors for Github/Actions.
Could you please help check why the 4 ci/openshift-* checks failed ?

/retest

they could be flakes, or a regression in crun

@ityuhui: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

• /test kata-containers
• /test e2e-agnostic
• /test e2e-gcp
• /test images
• /test ami_fedora
• /test ami_rhel
• /test critest_fedora
• /test critest_rhel
• /test e2e_crun
• /test e2e_cgroupv2
• /test e2e_features_fedora
• /test e2e_features_rhel
• /test e2e_fedora
• /test e2e_rhel
• /test integration_crun
• /test integration_cgroupv2
• /test integration_fedora
• /test integration_rhel

Use /test all to run the following jobs:

• kata-containers-crio-PR
• pull-ci-cri-o-cri-o-master-e2e-agnostic
• pull-ci-cri-o-cri-o-master-e2e-gcp
• pull-ci-cri-o-cri-o-master-images
• test_pull_request_crio_critest_fedora
• test_pull_request_crio_critest_rhel
• test_pull_request_crio_e2e_crun_fedora
• test_pull_request_crio_e2e_crun_fedora_cgroupv2
• test_pull_request_crio_e2e_features_fedora
• test_pull_request_crio_e2e_features_rhel
• test_pull_request_crio_e2e_fedora
• test_pull_request_crio_e2e_rhel
• test_pull_request_crio_integration_crun_fedora
• test_pull_request_crio_integration_crun_fedora_cgroupv2
• test_pull_request_crio_integration_fedora
• test_pull_request_crio_integration_rhel

/retest

Hi @haircommander

I have retest 3 times, but there are still 3 ci/openshift-jenkins check failed.

the integration crun issue is hitting #4616
/retest

if it doesn't pass again, I'll override. it's not the fault of this PR

@saschagrunert @kolyshkin @umohnani8 @Mrunal @QiWang19 PTAL

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ityuhui, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

LGTM
assuming happy tests

/override ci/openshift-jenkins/integration_crun

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

/retest

Please review the full test history for this PR and help us cut down flakes.

/retest

Please review the full test history for this PR and help us cut down flakes.

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

/retest

Please review the full test history for this PR and help us cut down flakes.

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

/retest

Please review the full test history for this PR and help us cut down flakes.

@ityuhui: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

/override ci/openshift-jenkins/critest_rhel

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/critest_rhel

thanks a bunch for the contribution @ityuhui!