Thanks to visit codestin.com
Credit goes to github.com

Skip to content

crio-wipe: only clear storage if CleanShutdownFile is supported #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 29, 2021
Merged

crio-wipe: only clear storage if CleanShutdownFile is supported #4697

openshift-merge-robot merged 1 commit into from
Mar 29, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Mar 29, 2021

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

or else, we will unconditionally try to remove the whole directory after upgrading from 1.20,
rather than pointedly removing crio specific containers

Signed-off-by: Peter Hunt [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 29, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
rphillips
rphillips reviewed Mar 29, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 29, 2021 •
edited
Loading

Codecov Report

Merging #4697 (e1d0e9e) into master (3cf4a99) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head e1d0e9e differs from pull request most recent head 4c7ce2c. Consider uploading reports for the commit 4c7ce2c to get more accurate results

@@            Coverage Diff             @@
##           master    #4697      +/-   ##
==========================================
- Coverage   41.29%   41.27%   -0.03%     
==========================================
  Files         110      110              
  Lines        9596     9597       +1     
==========================================
- Hits         3963     3961       -2     
- Misses       5182     5185       +3     
  Partials      451      451

@haircommander
crio-wipe: only clear storage if CleanShutdownFile is supported
4c7ce2c 
or else, we will unconditionally try to remove the whole directory after upgrading from 1.20,
rather than pointedly removing crio specific containers

Signed-off-by: Peter Hunt <[email protected]>
@haircommander haircommander force-pushed the clean-shutdown-supported branch from 0a55f8d to 4c7ce2c Compare March 29, 2021 18:21
@haircommander
Copy link
Member Author

haircommander commented Mar 29, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 4c7ce2c link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Mar 29, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit cfb670f into cri-o:master Mar 29, 2021
@openshift-ci openshift-ci bot mentioned this pull request May 14, 2021
Merged
This was referenced Aug 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@vrothberg vrothberg Awaiting requested review from vrothberg

+1 more reviewer

@rphillips rphillips rphillips left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-ci-robot @mrunalp @rphillips @openshift-merge-robot