Thanks to visit codestin.com
Credit goes to github.com

Skip to content

nsmgr: fix some leaks with GetNamespace #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Apr 23, 2021
Merged

nsmgr: fix some leaks with GetNamespace #4758

openshift-merge-robot merged 2 commits into from
Apr 23, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Apr 14, 2021

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

If we fail to initially attach the namespaces, we need to cleanup the ones we've already created
Also, we are currently unconditionally recreating the namespaces when restoring. I believe that's from a rebase issue

Signed-off-by: Peter Hunt [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug where CRI-O would leak opened files for namespaces on a server restore

@haircommander
nsmgr: fix some leaks with GetNamespace
da82be8 
If we fail to initially attach the namespaces, we need to cleanup the ones we've already created
Also, we are currently unconditionally recreating the namespaces when restoring. I believe that's from a rebase issue

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 14, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #4758 (180b9fb) into master (bc1ef35) will increase coverage by 0.11%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
+ Coverage   43.09%   43.20%   +0.11%     
==========================================
  Files         107      107              
  Lines        9754     9741      -13     
==========================================
+ Hits         4203     4209       +6     
+ Misses       5098     5083      -15     
+ Partials      453      449       -4

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Apr 14, 2021

LGTM
assuming happy tests

@saschagrunert
Copy link
Member

saschagrunert commented Apr 15, 2021

/retest

saschagrunert
saschagrunert approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Apr 22, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@haircommander
Copy link
Member Author

haircommander commented Apr 22, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Apr 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member Author

haircommander commented Apr 22, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Apr 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 23, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 23, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 180b9fb link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

haircommander commented Apr 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 98163fd into cri-o:master Apr 23, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 23, 2021

@haircommander: new pull request created: #4795

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@sameo sameo Awaiting requested review from sameo

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@haircommander @TomSweeneyRedHat @saschagrunert @openshift-ci-robot @mrunalp @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot