-
Notifications
You must be signed in to change notification settings - Fork 1.1k
server: use background context for network stop #4851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
or else the cleanup will always fail on cleanup from context deadline Signed-off-by: Peter Hunt <[email protected]>
|
/approve thanks, @haircommander |
Codecov Report
@@ Coverage Diff @@
## master #4851 +/- ##
==========================================
+ Coverage 42.98% 43.00% +0.01%
==========================================
Files 107 107
Lines 9792 9795 +3
==========================================
+ Hits 4209 4212 +3
Misses 5132 5132
Partials 451 451 |
|
LGTM |
|
/retest |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio, haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
or else the cleanup will always fail on cleanup from context deadline
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
pick of #4817
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?