[1.21] server: use background context for network stop #4852
Conversation
or else the cleanup will always fail on cleanup from context deadline Signed-off-by: Peter Hunt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.21 #4852 +/- ##
================================================
- Coverage 43.18% 43.17% -0.01%
================================================
Files 107 107
Lines 9752 9755 +3
================================================
+ Hits 4211 4212 +1
- Misses 5090 5092 +2
Partials 451 451 |
|
/retest |
1 similar comment
|
/retest |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
or else the cleanup will always fail on cleanup from context deadline
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
pick of #4851
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?