runtimeVM: Use internal context to ensure goroutines are stopped #4879
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9dbad13 to
156df02
Compare
Codecov Report
@@ Coverage Diff @@
## master #4879 +/- ##
=======================================
Coverage 42.98% 42.98%
=======================================
Files 107 107
Lines 9809 9809
=======================================
Hits 4216 4216
Misses 5142 5142
Partials 451 451 |
|
/retest |
cri-o#4803 partially reverted cri-o#4650, but ended up missing two places where the context is used to ensure the goroutines are stopped. This was caught due to some tests failing in a non deterministic manner on kata-containers CI. Related: - cri-o#4798 - kata-containers/tests#3503 (comment) Signed-off-by: Fabiano Fidêncio <[email protected]>
156df02 to
db280b4
Compare
|
/cc @wainersm |
|
LGTM |
saschagrunert
left a comment
There was a problem hiding this comment.
/lgtm
/cherry-pick release-1.21
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/openshift-jenkins/integration_crun |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@fidencio: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@haircommander, shall I override the integration_crun CI again? |
|
/cherry-pick release-1.21 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
#4803 partially reverted
#4650, but ended up missing two
places where the context is used to ensure the goroutines are stopped.
Which issue(s) this PR fixes:
Fixes #4798
Special notes for your reviewer:
This was caught due to some tests failing in a non deterministic manner
on kata-containers CI.
Related:
kata-containers/tests#3503 (comment)
Does this PR introduce a user-facing change?