Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release-1.21 | runtimeVM: Use internal context to ensure goroutines are stopped #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 12, 2021
Merged

release-1.21 | runtimeVM: Use internal context to ensure goroutines are stopped #4890

openshift-merge-robot merged 1 commit into from
May 12, 2021

Conversation

@fidencio
Copy link
Contributor

@fidencio fidencio commented May 11, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

#4803 partially reverted
#4650, but ended up missing two
places where the context is used to ensure the goroutines are stopped.

Which issue(s) this PR fixes:

Fixes #4798

Special notes for your reviewer:

This was caught due to some tests failing in a non deterministic manner
on kata-containers CI.

Related:
kata-containers/tests#3503 (comment)

This is a backport of #4879

Does this PR introduce a user-facing change?

None

@fidencio
runtimeVM: Use internal context to ensure goroutines are stopped
a529c77 
cri-o#4803 partially reverted
cri-o#4650, but ended up missing two
places where the context is used to ensure the goroutines are stopped.

This was caught due to some tests failing in a non deterministic manner
on kata-containers CI.

Related:
- cri-o#4798
- kata-containers/tests#3503 (comment)

Signed-off-by: Fabiano Fidêncio <[email protected]>
(cherry picked from commit db280b4)
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 11, 2021
@openshift-ci openshift-ci bot requested review from kolyshkin and saschagrunert May 11, 2021 13:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@fidencio
Copy link
Contributor Author

fidencio commented May 11, 2021

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

@fidencio: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test kata-containers
  • /test ami_fedora
  • /test ami_rhel
  • /test critest_fedora
  • /test critest_rhel
  • /test e2e_crun
  • /test e2e_cgroupv2
  • /test e2e_features_fedora
  • /test e2e_features_rhel
  • /test e2e_fedora
  • /test e2e_rhel
  • /test integration_crun
  • /test integration_cgroupv2
  • /test integration_fedora
  • /test integration_rhel
  • /test e2e-aws
  • /test images

Use /test all to run the following jobs:

  • kata-containers-crio-PR
  • test_pull_request_crio_critest_fedora
  • test_pull_request_crio_critest_rhel
  • test_pull_request_crio_e2e_crun_fedora
  • test_pull_request_crio_e2e_crun_fedora_cgroupv2
  • test_pull_request_crio_e2e_features_fedora
  • test_pull_request_crio_e2e_features_rhel
  • test_pull_request_crio_e2e_fedora
  • test_pull_request_crio_e2e_rhel
  • test_pull_request_crio_integration_crun_fedora
  • test_pull_request_crio_integration_crun_fedora_cgroupv2
  • test_pull_request_crio_integration_fedora
  • test_pull_request_crio_integration_rhel
  • pull-ci-cri-o-cri-o-release-1.21-e2e-aws
  • pull-ci-cri-o-cri-o-release-1.21-images
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fidencio
Copy link
Contributor Author

fidencio commented May 11, 2021

/retest

2 similar comments
@fidencio
Copy link
Contributor Author

fidencio commented May 11, 2021

/retest

@fidencio
Copy link
Contributor Author

fidencio commented May 11, 2021

/retest

saschagrunert
saschagrunert approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [fidencio,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021 •
edited
Loading

@fidencio: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 a529c77 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8f8bcd9 into cri-o:release-1.21 May 12, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jun 8, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fidencio @openshift-bot @saschagrunert @openshift-merge-robot