Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resource store: prevent segfault on cleanup step #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 5, 2021
Merged

resource store: prevent segfault on cleanup step #4834

openshift-merge-robot merged 1 commit into from
May 5, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented May 3, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

if a resource has a watcher, but has not yet been put to the store, we should not be marking it as stale.

Signed-off-by: Peter Hunt [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

related to https://bugzilla.redhat.com/show_bug.cgi?id=1955596

Does this PR introduce a user-facing change?

Fix a segfault when CRI-O has takes more than 8 minutes to create a pod or container

@haircommander
resource store: prevent segfault on cleanup step
70e7bee 
if a resource has a watcher, but has not yet been put to the store, we should not be marking it as stale.

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 3, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@haircommander
Copy link
Member Author

haircommander commented May 3, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 3, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

haircommander commented May 3, 2021

/cherry-pick release-1.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 3, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

haircommander commented May 3, 2021

/cherry-pick release-1.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 3, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #4834 (2911f4c) into master (1f2639c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2911f4c differs from pull request most recent head 70e7bee. Consider uploading reports for the commit 70e7bee to get more accurate results

@@            Coverage Diff             @@
##           master    #4834      +/-   ##
==========================================
+ Coverage   42.98%   43.00%   +0.01%     
==========================================
  Files         107      107              
  Lines        9792     9795       +3     
==========================================
+ Hits         4209     4212       +3     
  Misses       5132     5132              
  Partials      451      451

saschagrunert
saschagrunert approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mrunalp
mrunalp approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented May 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

openshift-bot commented May 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 70e7bee link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented May 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member

saschagrunert commented May 5, 2021

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2021

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-agnostic, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6b6b54e into cri-o:master May 5, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 5, 2021

@haircommander: new pull request created: #4846

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 5, 2021

@haircommander: new pull request created: #4847

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 5, 2021

@haircommander: new pull request created: #4848

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @saschagrunert @mrunalp @openshift-merge-robot