oci: fix issues with exec #4999
Conversation
or else we race with the runtime for creation Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.21 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.20 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.19 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4999 +/- ##
==========================================
- Coverage 42.56% 42.55% -0.01%
==========================================
Files 107 107
Lines 9966 9968 +2
==========================================
Hits 4242 4242
- Misses 5270 5272 +2
Partials 454 454 |
|
/retest |
1 similar comment
|
/retest |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // only kill the runtime process if we failed to find a ctrPid | ||
| // as this means the runtime exec hasn't successfully written the pid file | ||
| if killErr := cmd.Process.Kill(); killErr != nil { | ||
| log.Errorf(ctx, "Error killing runtime exec process(%v) after error finding runtime pid: (%v)", killErr, err) |
There was a problem hiding this comment.
nit: `after error finding container exec pid" (can be done later).
mrunalp
left a comment
There was a problem hiding this comment.
We also want to address not waiting indefinitely after the SIGKILL as a follow-on as process could get stuck in D state.
|
/lgtm |
|
@haircommander: new pull request created: #5000 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #5001 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #5002 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it
previously we had lots of instances of
Failed to get pid (-1) or pgid (-1) from file /tmp/pidfile097828553: strconv.Atoi: parsing \"\": invalid syntax"because we precreated the pid file. stop doing this, and also kill the runtime process if we timeout an exec run
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?