oci: use conmon for exec again #5245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5245 +/- ##
==========================================
- Coverage 44.12% 43.68% -0.44%
==========================================
Files 117 116 -1
Lines 11650 11662 +12
==========================================
- Hits 5140 5094 -46
- Misses 6024 6086 +62
+ Partials 486 482 -4 |
|
LGTM |
|
/retest |
|
The log capitalization test needs to be fixed :) |
After a long saga of bug fixing and issue squashing, it turns out this is not the correct approach. Naively, one may exepct removing conmon from the picture would help reduce the load on the system. However, the way the go runtime hogs memory after it's been aquired, and because conmon is comparatively lighter weight, dropping conmon from exec syncs causes a memory regression in CRI-O. We will have to find a new solution for the excessive defunct processes. Signed-off-by: Peter Hunt <[email protected]>
67001f2 to
6a8cb41
Compare
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
After a long saga of bug fixing and issue squashing, it turns out this is not the correct approach.
Naively, one may exepct removing conmon from the picture would help reduce the load on the system.
However, the way the go runtime hogs memory after it's been aquired, and because conmon is comparatively lighter weight,
dropping conmon from exec syncs causes a memory regression in CRI-O.
We will have to find a new solution for the excessive defunct processes.
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
reverts #4943 #4999 #5067 #5107 #5136
Does this PR introduce a user-facing change?