Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.20] oci: fix issues with exec #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jun 16, 2021
Merged

[release-1.20] oci: fix issues with exec #5000

openshift-merge-robot merged 2 commits into from
Jun 16, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 16, 2021

This is an automated cherry-pick of #4999

/assign haircommander

Fix a bug where an exec sync timeout would fail to cleanup the runtime exec process

@haircommander
oci: don't pre-create pid file
05a5a0f 
or else we race with the runtime for creation

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
oci: kill runtime process on exec if exec pid isn't written yet
60b238d 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2021
Merged
@openshift-ci openshift-ci bot requested review from fidencio and kolyshkin June 16, 2021 00:57
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #5000 (60b238d) into release-1.20 (845b2fa) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.20    #5000      +/-   ##
================================================
- Coverage         41.22%   41.21%   -0.01%     
================================================
  Files               117      117              
  Lines              9487     9489       +2     
================================================
  Hits               3911     3911              
- Misses             5124     5126       +2     
  Partials            452      452

saschagrunert
saschagrunert approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@saschagrunert
Copy link
Member

saschagrunert commented Jun 16, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit baade70 into cri-o:release-1.20 Jun 16, 2021
@openshift-ci openshift-ci bot mentioned this pull request Aug 30, 2021
Merged
@lack lack mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @saschagrunert @openshift-bot @haircommander @openshift-merge-robot