Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] oci: fix issues with exec #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jun 16, 2021
Merged

[release-1.21] oci: fix issues with exec #5002

openshift-merge-robot merged 2 commits into from
Jun 16, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 16, 2021

This is an automated cherry-pick of #4999

/assign haircommander

Fix a bug where an exec sync timeout would fail to cleanup the runtime exec process

@haircommander
oci: don't pre-create pid file
c7c6aba 
or else we race with the runtime for creation

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
oci: kill runtime process on exec if exec pid isn't written yet
5f7db4b 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2021
Merged
@openshift-ci openshift-ci bot requested review from sameo and vrothberg June 16, 2021 00:59
mrunalp
mrunalp approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #5002 (5f7db4b) into release-1.21 (7e41de0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.21    #5002      +/-   ##
================================================
- Coverage         43.27%   43.26%   -0.01%     
================================================
  Files               107      107              
  Lines              9837     9839       +2     
================================================
  Hits               4257     4257              
- Misses             5126     5128       +2     
  Partials            454      454

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 5f7db4b link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert
saschagrunert approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert
Copy link
Member

saschagrunert commented Jun 16, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dfcd2b6 into cri-o:release-1.21 Jun 16, 2021
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@sameo sameo Awaiting requested review from sameo

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mrunalp mrunalp

@saschagrunert saschagrunert

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @saschagrunert @openshift-bot @mrunalp @haircommander @openshift-merge-robot