Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix missing quantile in latency_microseconds_total metrics #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 27, 2021
Merged

Fix missing quantile in latency_microseconds_total metrics #5258

openshift-merge-robot merged 1 commit into from
Aug 27, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 27, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

The quantile has to be added manually since a couple of prometheus
client releases and we missed that. Adding an integration test to ensure
that the quantile exist in the future.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed missing quantile values in `container_runtime_crio_operations_latency_microseconds_total` metrics

@saschagrunert
Fix missing quantile in latency_microseconds_total metrics
05e6624 
The quantile has to be added manually since a couple of prometheus
client releases and we missed that. Adding an integration test to ensure
that the quantile exist in the future.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 27, 2021
@openshift-ci openshift-ci bot requested a review from vrothberg August 27, 2021 09:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 27, 2021

/cherry-pick release-1.22
/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2021

@saschagrunert: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.22
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5258 (c69892a) into master (3a92f62) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head c69892a differs from pull request most recent head 05e6624. Consider uploading reports for the commit 05e6624 to get more accurate results

@@            Coverage Diff             @@
##           master    #5258      +/-   ##
==========================================
- Coverage   43.78%   43.76%   -0.03%     
==========================================
  Files         118      118              
  Lines       11720    11721       +1     
==========================================
- Hits         5132     5130       -2     
- Misses       6101     6104       +3     
  Partials      487      487

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 27, 2021

/test e2e_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 27, 2021

/test kata-containers

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 05e6624 link /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 05e6624 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Aug 27, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2021
@openshift-bot
Copy link

openshift-bot commented Aug 27, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f85d0be into cri-o:master Aug 27, 2021
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2021

@saschagrunert: #5258 failed to apply on top of branch "release-1.21":

Applying: Fix missing quantile in `latency_microseconds_total` metrics
Using index info to reconstruct a base tree...
M	server/metrics/metrics.go
M	test/metrics.bats
Falling back to patching base and 3-way merge...
Auto-merging test/metrics.bats
CONFLICT (content): Merge conflict in test/metrics.bats
Auto-merging server/metrics/metrics.go
CONFLICT (content): Merge conflict in server/metrics/metrics.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix missing quantile in `latency_microseconds_total` metrics
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-1.22
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2021

@saschagrunert: new pull request created: #5259

Details

In response to this:

/cherry-pick release-1.22
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert deleted the metrics-quantile branch August 27, 2021 14:57
This was referenced Aug 30, 2021
Merged
Merged
Merged
@littlejawa littlejawa mentioned this pull request Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saschagrunert @openshift-cherrypick-robot @haircommander @openshift-bot @openshift-merge-robot