Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saschagrunert
Copy link
Member

This is an automated cherry-pick of #5258

Fixed missing quantile values in `container_runtime_crio_operations_latency_microseconds_total` metrics

The quantile has to be added manually since a couple of prometheus
client releases and we missed that. Adding an integration test to ensure
that the quantile exist in the future.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 30, 2021
@openshift-ci openshift-ci bot requested a review from sameo August 30, 2021 07:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from vrothberg August 30, 2021 07:42
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@saschagrunert saschagrunert changed the title Fix missing quantile in latency_microseconds_total metrics [release-1.19] Fix missing quantile in latency_microseconds_total metrics Aug 30, 2021
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert saschagrunert changed the title [release-1.19] Fix missing quantile in latency_microseconds_total metrics [release-1.19] Fix missing quantile in latency_microseconds_total metrics Aug 30, 2021
@saschagrunert
Copy link
Member Author

/retest
@cri-o/cri-o-maintainers PTAL

@saschagrunert saschagrunert changed the title [release-1.19] Fix missing quantile in latency_microseconds_total metrics [release-1.19] BZ#2010841 Fix missing quantile in latency_microseconds_total metrics Oct 5, 2021
@saschagrunert
Copy link
Member Author

@haircommander PTAL

@saschagrunert
Copy link
Member Author

@haircommander PTAL
/retest-required

@haircommander
Copy link
Member

/lgtm
/override ci/openshift-jenkins/integration_rhel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel

Details

In response to this:

/lgtm
/override ci/openshift-jenkins/integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 a64ecaf link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 74187ba into cri-o:release-1.19 Feb 16, 2022
@saschagrunert saschagrunert deleted the release-1.19-metrics-quantile branch February 17, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants