-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.19] BZ#2010841 Fix missing quantile in latency_microseconds_total metrics
#5264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.19] BZ#2010841 Fix missing quantile in latency_microseconds_total metrics
#5264
Conversation
The quantile has to be added manually since a couple of prometheus client releases and we missed that. Adding an integration test to ensure that the quantile exist in the future. Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
latency_microseconds_total metrics
|
/retest |
latency_microseconds_total metricslatency_microseconds_total metrics
|
@haircommander PTAL |
|
@haircommander PTAL |
|
/lgtm |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This is an automated cherry-pick of #5258