Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not log on startup if Intel RDT is not supported #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 10, 2021
Merged

Do not log on startup if Intel RDT is not supported #5293

openshift-merge-robot merged 1 commit into from
Sep 10, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 10, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reduces the noise on systems not having Intel RDT enabled. We already log that RDT is not enabled on profile load.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Do not log on startup if Intel RDT is not supported.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2021
@saschagrunert
Do not log if Intel RDT is not supported
15f7f7e 
This reduces the noise on systems not having Intel RDT enabled.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert changed the title Log in debug mode if Intel RDT is not supported Do not log on startup if Intel RDT is not supported Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #5293 (a9a3457) into master (74a5cf8) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a9a3457 differs from pull request most recent head 15f7f7e. Consider uploading reports for the commit 15f7f7e to get more accurate results

@@           Coverage Diff           @@
##           master    #5293   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files         118      118           
  Lines       11723    11722    -1     
=======================================
  Hits         5126     5126           
+ Misses       6110     6109    -1     
  Partials      487      487

@haircommander
Copy link
Member

haircommander commented Sep 10, 2021

would you remove the corresponding one in internal/config/blockio/blockio.go as well?

@fgiudici
Copy link
Contributor

fgiudici commented Sep 10, 2021

would you remove the corresponding one in internal/config/blockio/blockio.go as well?

Hey Peter, do you mean to remove the log from the Load() in blockio.go as well? If so, wouldn't that be a bit different than here (removing the log from the New() only)?

@haircommander
Copy link
Member

haircommander commented Sep 10, 2021

would you remove the corresponding one in internal/config/blockio/blockio.go as well?

Hey Peter, do you mean to remove the log from the Load() in blockio.go as well? If so, wouldn't that be a bit different than here (removing the log from the New() only)?

you are right! nevermind haha

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021
@haircommander
Copy link
Member

haircommander commented Sep 10, 2021

/cherry-pick release-1.22

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 10, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 15f7f7e link /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 15f7f7e link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fgiudici
Copy link
Contributor

fgiudici commented Sep 10, 2021

lgtm

@openshift-merge-robot openshift-merge-robot merged commit 59e5f02 into cri-o:master Sep 10, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 10, 2021

@haircommander: new pull request created: #5298

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert deleted the rdt-debug branch June 23, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saschagrunert @haircommander @fgiudici @openshift-cherrypick-robot @openshift-merge-robot