Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.22] Do not log on startup if Intel RDT is not supported #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 13, 2021
Merged

[release-1.22] Do not log on startup if Intel RDT is not supported #5298

openshift-merge-robot merged 1 commit into from
Sep 13, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 10, 2021

This is an automated cherry-pick of #5293

/assign haircommander

Do not log on startup if Intel RDT is not supported.

@saschagrunert
Do not log if Intel RDT is not supported
764e83f 
This reduces the noise on systems not having Intel RDT enabled.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 10, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2021
Merged
@haircommander
Copy link
Member

haircommander commented Sep 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #5298 (764e83f) into release-1.22 (148b8c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.22    #5298   +/-   ##
=============================================
  Coverage         43.74%   43.74%           
=============================================
  Files               118      118           
  Lines             11727    11726    -1     
=============================================
  Hits               5130     5130           
+ Misses             6110     6109    -1     
  Partials            487      487

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 764e83f link /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 764e83f link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Sep 13, 2021

fixes #5302
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@haircommander haircommander mentioned this pull request Sep 13, 2021
Closed
@openshift-merge-robot openshift-merge-robot merged commit 7a3c55d into cri-o:release-1.22 Sep 13, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @haircommander @openshift-merge-robot @saschagrunert