Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix shfmt #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 21, 2021
Merged

fix shfmt #5316

openshift-merge-robot merged 1 commit into from
Sep 21, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 16, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind ci

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
fix shfmt
f5ebb6c 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI labels Sep 16, 2021
@openshift-ci openshift-ci bot requested review from nalind and rhatdan September 16, 2021 14:03
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2021
@nalind
Copy link
Collaborator

nalind commented Sep 16, 2021

LGTM

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #5316 (f5ebb6c) into main (61e0841) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5316      +/-   ##
==========================================
+ Coverage   43.71%   43.73%   +0.01%     
==========================================
  Files         118      118              
  Lines       11727    11727              
==========================================
+ Hits         5127     5129       +2     
+ Misses       6112     6110       -2     
  Partials      488      488

@haircommander
Copy link
Member Author

haircommander commented Sep 16, 2021

/retest-required

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 16, 2021

LGTM
now to get that one last test to be happy.

@haircommander
Copy link
Member Author

haircommander commented Sep 17, 2021

/retest

@haircommander haircommander mentioned this pull request Sep 20, 2021
Merged
@haircommander
Copy link
Member Author

haircommander commented Sep 20, 2021

@wgahnagl @QiWang19 @fgiudici PTAL

@fgiudici
Copy link
Contributor

fgiudici commented Sep 20, 2021

LGTM!

@QiWang19
Copy link
Member

QiWang19 commented Sep 20, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

kolyshkin
kolyshkin approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kolyshkin, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,kolyshkin,nalind]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 f5ebb6c link /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 f5ebb6c link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member Author

haircommander commented Sep 21, 2021

/override ci/openshift-jenkins/e2e_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/e2e_crun

Details

In response to this:

/override ci/openshift-jenkins/e2e_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 5a2ed3f into cri-o:main Sep 21, 2021
@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nalind nalind nalind approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@QiWang19 QiWang19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@haircommander @nalind @TomSweeneyRedHat @fgiudici @QiWang19 @openshift-bot @kolyshkin @openshift-merge-robot