Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add unit test for the server/sandbox_remove. #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 22, 2021
Merged

Add unit test for the server/sandbox_remove. #5328

openshift-merge-robot merged 1 commit into from
Sep 22, 2021

Conversation

@utam0k
Copy link
Contributor

@utam0k utam0k commented Sep 18, 2021

Signed-off-by: utam0k [email protected]

What type of PR is this?

/kind other

What this PR does / why we need it:

Add unit test for the server/sandbox_remove to increase code coverage.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category labels Sep 18, 2021
@openshift-ci openshift-ci bot requested review from fidencio and rhatdan September 18, 2021 15:34
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2021

Hi @utam0k. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 18, 2021 •
edited
Loading

Codecov Report

Merging #5328 (defbd7f) into main (5a2ed3f) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head defbd7f differs from pull request most recent head c6f1ed4. Consider uploading reports for the commit c6f1ed4 to get more accurate results

@@            Coverage Diff             @@
##             main    #5328      +/-   ##
==========================================
+ Coverage   43.68%   43.75%   +0.06%     
==========================================
  Files         118      118              
  Lines       11737    11737              
==========================================
+ Hits         5127     5135       +8     
+ Misses       6122     6114       -8     
  Partials      488      488

@haircommander
Copy link
Member

haircommander commented Sep 20, 2021

/ok-to-test
/approve

thanks, LGTM

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2021
@utam0k
Copy link
Contributor Author

utam0k commented Sep 20, 2021

@haircommander Can I fix the shfmt error?

@haircommander
Copy link
Member

haircommander commented Sep 20, 2021

no need it'll be fixed by #5316

fgiudici
fgiudici approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just found a typo in a message)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 21, 2021
@utam0k utam0k force-pushed the improvement/add-test-server-sandbox_remove branch from 92c1597 to d34b150 Compare September 21, 2021 06:11
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 21, 2021
@utam0k
Copy link
Contributor Author

utam0k commented Sep 21, 2021

/retest-required

@fgiudici
Copy link
Contributor

fgiudici commented Sep 21, 2021

/retest

@fgiudici
Copy link
Contributor

fgiudici commented Sep 21, 2021

Hey @utam0k , the last commit looks a bit weird to me (the merge one).
My guess is that you intended to rebase your branch on the main branch... if so, you may want probably to:
git rebase origin/main
and than force push your branch again.

@utam0k utam0k force-pushed the improvement/add-test-server-sandbox_remove branch from d34b150 to 912fce2 Compare September 21, 2021 13:47
@utam0k
Copy link
Contributor Author

utam0k commented Sep 21, 2021

Hey @utam0k , the last commit looks a bit weird to me (the merge one).
My guess is that you intended to rebase your branch on the main branch... if so, you may want probably to:
git rebase origin/main
and than force push your branch again.

Ops... I have fixed it.

@utam0k
Copy link
Contributor Author

utam0k commented Sep 21, 2021

/retest-required

@haircommander
Copy link
Member

haircommander commented Sep 21, 2021

One more nit, could you squash the two commits into one @utam0k ?

@utam0k utam0k force-pushed the improvement/add-test-server-sandbox_remove branch from 912fce2 to c6f1ed4 Compare September 21, 2021 14:38
@utam0k
Copy link
Contributor Author

utam0k commented Sep 21, 2021

@haircommander I have squashed them.

@haircommander
Copy link
Member

haircommander commented Sep 21, 2021

/retest
/lgtm

thanks @utam0k !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@utam0k
Copy link
Contributor Author

utam0k commented Sep 21, 2021

@haircommander Why are these tests failing? I feel like they are not failing with my changes. Is this an existing problem?

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Sep 21, 2021

they're certainly unrelated :)

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Sep 21, 2021

/override e2e_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@haircommander: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e_crun

Only the following contexts were expected:

  • ci/kata-jenkins
  • ci/openshift-jenkins/critest_fedora
  • ci/openshift-jenkins/critest_rhel
  • ci/openshift-jenkins/e2e_crun
  • ci/openshift-jenkins/e2e_crun_cgroupv2
  • ci/openshift-jenkins/e2e_features_fedora
  • ci/openshift-jenkins/e2e_features_rhel
  • ci/openshift-jenkins/e2e_fedora
  • ci/openshift-jenkins/e2e_rhel
  • ci/openshift-jenkins/integration_crun
  • ci/openshift-jenkins/integration_crun_cgroupv2
  • ci/openshift-jenkins/integration_fedora
  • ci/openshift-jenkins/integration_rhel
  • ci/prow/e2e-agnostic
  • ci/prow/e2e-gcp
  • ci/prow/images
  • dco
  • kata-containers-2-crio-PR
  • lift
  • pull-ci-cri-o-cri-o-main-e2e-agnostic
  • pull-ci-cri-o-cri-o-main-e2e-gcp
  • pull-ci-cri-o-cri-o-main-images
  • test_pull_request_crio_critest_fedora
  • test_pull_request_crio_critest_rhel
  • test_pull_request_crio_e2e_crun_fedora
  • test_pull_request_crio_e2e_crun_fedora_cgroupv2
  • test_pull_request_crio_e2e_features_fedora
  • test_pull_request_crio_e2e_features_rhel
  • test_pull_request_crio_e2e_fedora
  • test_pull_request_crio_e2e_rhel
  • test_pull_request_crio_integration_crun_fedora
  • test_pull_request_crio_integration_crun_fedora_cgroupv2
  • test_pull_request_crio_integration_fedora
  • test_pull_request_crio_integration_rhel
  • tide
Details

In response to this:

/override e2e_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

haircommander commented Sep 21, 2021

/override ci/openshift-jenkins/e2e_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/e2e_crun

Details

In response to this:

/override ci/openshift-jenkins/e2e_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Sep 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021 •
edited
Loading

@utam0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 c6f1ed4 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 c6f1ed4 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9358b2e into cri-o:main Sep 22, 2021
@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@rhatdan rhatdan Awaiting requested review from rhatdan

1 more reviewer

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@utam0k @haircommander @fgiudici @openshift-bot @openshift-merge-robot