server: close namespaces on sandbox stop #5336
Conversation
3735038 to
7e40a6e
Compare
|
LGTM |
e1ead9f to
530ab81
Compare
Codecov Report
@@ Coverage Diff @@
## main #5336 +/- ##
=======================================
Coverage 43.52% 43.53%
=======================================
Files 118 118
Lines 11890 11895 +5
=======================================
+ Hits 5175 5178 +3
- Misses 6220 6224 +4
+ Partials 495 493 -2 |
|
/test e2e-gcp |
|
/retest |
|
@cri-o/cri-o-maintainers PTAL |
530ab81 to
fbcdae6
Compare
mrunalp
left a comment
There was a problem hiding this comment.
Can we drop the first commit as we are overwriting it in the second commit?
6b8d003 to
35a399d
Compare
|
comments addressed and tests should be fixed, PTAL @cri-o/cri-o-maintainers |
Signed-off-by: Peter Hunt <[email protected]>
35a399d to
efcf8af
Compare
|
PTAL @cri-o/cri-o-maintainers |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-1.22 |
|
@haircommander: new pull request created: #5477 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.21 |
|
@haircommander: new pull request created: #5478 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
or else namespaces will appear to leak before kubelet GCs the associated pods.
To do so, do all of the namespace unmounting pieces on stop, but don't actually delete the file.
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?