Refactor internal types to reduce needless copying #5409
Conversation
Signed-off-by: Peter Hunt <[email protected]>
c6d6e2c to
46dd6eb
Compare
saschagrunert
left a comment
There was a problem hiding this comment.
Generally love this refactoring. Unfortunately a timestamp related unit test is now failing.
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
46dd6eb to
9777398
Compare
Codecov Report
@@ Coverage Diff @@
## main #5409 +/- ##
==========================================
- Coverage 43.72% 43.50% -0.22%
==========================================
Files 118 118
Lines 11752 11786 +34
==========================================
- Hits 5139 5128 -11
- Misses 6125 6166 +41
- Partials 488 492 +4 |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
it turns out, at steady state, a lot of our cpu time is spent doing garbage collection. These commits represent some low hanging fruit for reducing the number of objects we create at steady state, which will in turn reduce the amount of garbage collection that happens. It focuses on List{Containers,PodSandboxes} as these are pretty hot paths.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?