deep copy List{PodSandbox,Container} structs #5606
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5606 +/- ##
==========================================
- Coverage 43.24% 43.19% -0.06%
==========================================
Files 123 123
Lines 12220 12234 +14
==========================================
- Hits 5285 5284 -1
- Misses 6427 6442 +15
Partials 508 508 |
|
fallout of #5409 |
|
/retest |
|
/cherry-pick release-1.23 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM |
Unfortunately, since each struct has state, if we directly edit the structure then protobuf panics Signed-off-by: Peter Hunt <[email protected]>
38a7ed4 to
a7ac468
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-agnostic |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #5611 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Unfortunately, since each struct has state, if we directly edit the structure then protobuf panics
Signed-off-by: Peter Hunt [email protected]
/kind bug
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?