[release-1.23] deep copy List{PodSandbox,Container} structs #5611
Conversation
Unfortunately, since each struct has state, if we directly edit the structure then protobuf panics Signed-off-by: Peter Hunt <[email protected]>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.23 #5611 +/- ##
================================================
- Coverage 43.22% 43.21% -0.01%
================================================
Files 123 123
Lines 12213 12215 +2
================================================
Hits 5279 5279
- Misses 6427 6429 +2
Partials 507 507 |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/openshift-jenkins/integration_fedora |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_fedora DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #5606
/assign haircommander