Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: fix a potential NULL-pointer dereference. #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haircommander merged 1 commit into from
Jan 27, 2022
Merged

server: fix a potential NULL-pointer dereference. #5579

haircommander merged 1 commit into from
Jan 27, 2022

Conversation

@klihub
Copy link
Contributor

@klihub klihub commented Jan 27, 2022

Fix a potential NULL-pointer dereference in a log message.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a potential NULL-pointer dereference in a log message that could crash the daemon.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Fix a potential crash caused by a log message NULL-pointer dereference.

@klihub
server: fix a potential NULL-pointer dereference.
35c02b5 
Fix a potential NULL-pointer dereference in logging.
A (cri-o) client could crash the daemon by sending
a CreateContainer request with a NULL Config.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested review from mrunalp and runcom as code owners January 27, 2022 17:35
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 27, 2022
@openshift-ci openshift-ci bot requested a review from giuseppe January 27, 2022 17:35
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

Hi @klihub. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2022
@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

/ok-to-test
/approve

LGTM, great catch @klihub !

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, klihub

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

/cherry-pick release-1.23

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 27, 2022

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #5579 (35c02b5) into main (13052a3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5579   +/-   ##
=======================================
  Coverage   43.22%   43.22%           
=======================================
  Files         123      123           
  Lines       12214    12214           
=======================================
  Hits         5280     5280           
  Misses       6426     6426           
  Partials      508      508

@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

/retest

@QiWang19
Copy link
Member

QiWang19 commented Jan 27, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@QiWang19
Copy link
Member

QiWang19 commented Jan 27, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@klihub: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_features_rhel 35c02b5 link true /test e2e_features_rhel
ci/openshift-jenkins/critest_fedora 35c02b5 link true /test critest_fedora
ci/openshift-jenkins/integration_fedora 35c02b5 link true /test integration_fedora
ci/openshift-jenkins/integration_crun 35c02b5 link true /test integration_crun
ci/openshift-jenkins/critest_rhel 35c02b5 link true /test critest_rhel
ci/openshift-jenkins/e2e_features_fedora 35c02b5 link true /test e2e_features_fedora
ci/openshift-jenkins/e2e_fedora 35c02b5 link true /test e2e_fedora
ci/openshift-jenkins/integration_rhel 35c02b5 link true /test integration_rhel
ci/openshift-jenkins/integration_crun_cgroupv2 35c02b5 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_rhel 35c02b5 link true /test e2e_rhel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander haircommander merged commit 5fb5640 into cri-o:main Jan 27, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 27, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 27, 2022

@haircommander: new pull request created: #5580

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@klihub klihub mentioned this pull request Feb 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

Assignees

@QiWang19 QiWang19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@klihub @haircommander @openshift-cherrypick-robot @QiWang19