Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.23] server: fix a potential NULL-pointer dereference. #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haircommander merged 1 commit into from
Jan 27, 2022
Merged

[release-1.23] server: fix a potential NULL-pointer dereference. #5580

haircommander merged 1 commit into from
Jan 27, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 27, 2022

This is an automated cherry-pick of #5579

/assign haircommander

Fix a potential crash caused by a log message NULL-pointer dereference.

@klihub
server: fix a potential NULL-pointer dereference.
8520be5 
Fix a potential NULL-pointer dereference in logging.
A (cri-o) client could crash the daemon by sending
a CreateContainer request with a NULL Config.

Signed-off-by: Krisztian Litkey <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 27, 2022
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 27, 2022
@openshift-ci openshift-ci bot requested a review from umohnani8 January 27, 2022 18:46
@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #5580 (f6166a1) into release-1.23 (db89312) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f6166a1 differs from pull request most recent head 8520be5. Consider uploading reports for the commit 8520be5 to get more accurate results

@@              Coverage Diff              @@
##           release-1.23    #5580   +/-   ##
=============================================
  Coverage         43.22%   43.22%           
=============================================
  Files               123      123           
  Lines             12210    12210           
=============================================
  Hits               5278     5278           
  Misses             6425     6425           
  Partials            507      507

@openshift-bot
Copy link

openshift-bot commented Jan 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 8520be5 link false /test integration_cgroupv2
ci/prow/e2e-gcp 8520be5 link true /test e2e-gcp
ci/prow/e2e-agnostic 8520be5 link true /test e2e-agnostic
ci/openshift-jenkins/e2e_features_fedora 8520be5 link true /test e2e_features_fedora
ci/openshift-jenkins/e2e_features_rhel 8520be5 link true /test e2e_features_rhel
ci/openshift-jenkins/integration_crun 8520be5 link true /test integration_crun
ci/openshift-jenkins/e2e_rhel 8520be5 link true /test e2e_rhel
ci/openshift-jenkins/integration_rhel 8520be5 link true /test integration_rhel
ci/openshift-jenkins/e2e_fedora 8520be5 link true /test e2e_fedora
ci/openshift-jenkins/integration_fedora 8520be5 link true /test integration_fedora
ci/openshift-jenkins/critest_fedora 8520be5 link true /test critest_fedora
ci/openshift-jenkins/critest_rhel 8520be5 link true /test critest_rhel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander haircommander merged commit 562c4e3 into cri-o:release-1.23 Jan 27, 2022
@openshift-ci openshift-ci bot mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @haircommander @openshift-bot @klihub