Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] server: close namespaces on sandbox stop #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 4, 2022
Merged

[release-1.21] server: close namespaces on sandbox stop #5502

openshift-merge-robot merged 1 commit into from
Jan 4, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 14, 2021

This is an automated cherry-pick of #5477

/assign haircommander

Move namespace cleanup from sandbox stop to sandbox remove. This allows veth entries in the network namespaces of pods to be cleaned up earlier

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 14, 2021
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 14, 2021
@openshift-ci openshift-ci bot requested review from fidencio and vrothberg December 14, 2021 00:45
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #5502 (156aad9) into release-1.21 (c845cf4) will increase coverage by 0.01%.
The diff coverage is 59.37%.

@@               Coverage Diff                @@
##           release-1.21    #5502      +/-   ##
================================================
+ Coverage         44.90%   44.92%   +0.01%     
================================================
  Files               107      107              
  Lines             10989    10994       +5     
================================================
+ Hits               4935     4939       +4     
- Misses             5573     5576       +3     
+ Partials            481      479       -2

@nee1esh
Copy link

nee1esh commented Dec 21, 2021

/retitle [release-1.21] server: close namespaces on sandbox stop

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@nee1esh: Re-titling can only be requested by trusted users, like repository collaborators.

Details

In response to this:

/retitle [release-1.21] server: close namespaces on sandbox stop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link

nee1esh commented Dec 21, 2021

/retest-required

@haircommander
Copy link
Member

haircommander commented Dec 21, 2021

/retitle [release-1.21] server: close namespaces on sandbox stop

@openshift-ci openshift-ci bot changed the title [release-1.21] [release-1.22] server: close namespaces on sandbox stop [release-1.21] server: close namespaces on sandbox stop Dec 21, 2021
@haircommander
Copy link
Member

haircommander commented Dec 21, 2021

related to https://bugzilla.redhat.com/show_bug.cgi?id=2026388

@haircommander
Copy link
Member

haircommander commented Jan 4, 2022

/lgtm
/approve

/override ci/openshift-jenkins/integration_crun

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/lgtm
/approve

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 156aad9 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 156aad9 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Jan 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 91c3cb8 into cri-o:release-1.21 Jan 4, 2022
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @nee1esh @haircommander @openshift-bot @openshift-merge-robot