Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.22] oci: always reap conmon zombies #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 16, 2021
Merged

[release-1.22] oci: always reap conmon zombies #5503

openshift-merge-robot merged 1 commit into from
Dec 16, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 14, 2021

This is an automated cherry-pick of #5500

/assign haircommander

Fix a case where conmon children are sometimes leaked

@haircommander
oci: always reap conmon zombies
72d7cba 
Even if we kill the process, we still need to wait for it, or else we'll reap a zombie.

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 14, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 14, 2021
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 14, 2021
@openshift-ci openshift-ci bot requested review from fidencio and vrothberg December 14, 2021 14:32
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #5503 (d1b8787) into release-1.22 (aeeadca) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d1b8787 differs from pull request most recent head 72d7cba. Consider uploading reports for the commit 72d7cba to get more accurate results

@@               Coverage Diff                @@
##           release-1.22    #5503      +/-   ##
================================================
- Coverage         43.74%   43.72%   -0.03%     
================================================
  Files               118      118              
  Lines             11779    11785       +6     
================================================
  Hits               5153     5153              
- Misses             6139     6145       +6     
  Partials            487      487

@haircommander
Copy link
Member

haircommander commented Dec 14, 2021

integration_crun failures seem reproducable

not ok 90 additional devices permissions
# (in test file ./devices.bats, line 61)
#   `[[ "$output" == *"Operation not permitted"* ]]' failed
# time="2021-12-14T14:53:42Z" level=warning msg="Support for the 'registries' option has been dropped but it is referenced in \"/etc/crio/crio.conf.d/01-registries.conf\".  Please use containers-registries.conf(5) for configuring unqualified-search registries instead."
# time="2021-12-14 14:53:42.769948629Z" level=info msg="Starting CRI-O, version: 1.22.1, git: 72d7cba2597d63e71d14d95d83a0e48b5f4e6569(dirty)"
# level=info msg="Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL"
# time="2021-12-14 14:53:43.145635334Z" level=info msg="Starting CRI-O, version: 1.22.1, git: 72d7cba2597d63e71d14d95d83a0e48b5f4e6569(dirty)"
# level=info msg="Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL"
# 4c62e76dcc2049bf3d5921e5e063a6cc98dc29260a7e7c76aa3894c3cdcfd7d9
# /dev/kmsg

cc @giuseppe

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@saschagrunert saschagrunert removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@saschagrunert
Copy link
Member

saschagrunert commented Dec 15, 2021

@haircommander do we have a BZ for this?

@saschagrunert saschagrunert added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@giuseppe
Copy link
Member

giuseppe commented Dec 15, 2021

integration_crun failures seem reproducable

not ok 90 additional devices permissions
# (in test file ./devices.bats, line 61)
#   `[[ "$output" == *"Operation not permitted"* ]]' failed
# time="2021-12-14T14:53:42Z" level=warning msg="Support for the 'registries' option has been dropped but it is referenced in \"/etc/crio/crio.conf.d/01-registries.conf\".  Please use containers-registries.conf(5) for configuring unqualified-search registries instead."
# time="2021-12-14 14:53:42.769948629Z" level=info msg="Starting CRI-O, version: 1.22.1, git: 72d7cba2597d63e71d14d95d83a0e48b5f4e6569(dirty)"
# level=info msg="Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL"
# time="2021-12-14 14:53:43.145635334Z" level=info msg="Starting CRI-O, version: 1.22.1, git: 72d7cba2597d63e71d14d95d83a0e48b5f4e6569(dirty)"
# level=info msg="Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL"
# 4c62e76dcc2049bf3d5921e5e063a6cc98dc29260a7e7c76aa3894c3cdcfd7d9
# /dev/kmsg

cc @giuseppe

yes sorry. I broke it few days ago :(

I've opened a PR to fix it: containers/crun#810

and working on adding CRI-O integration tests to the CI: containers/crun#811

/test integration_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 72d7cba link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 72d7cba link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Dec 15, 2021

/retest-required

@haircommander
Copy link
Member

haircommander commented Dec 15, 2021

@haircommander do we have a BZ for this?

yeah, https://bugzilla.redhat.com/show_bug.cgi?id=2032466

saschagrunert
saschagrunert approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f1d2c6e into cri-o:release-1.22 Dec 16, 2021
@haircommander
Copy link
Member

haircommander commented Dec 16, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 16, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Dec 16, 2021

@haircommander: new pull request created: #5510

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @haircommander @saschagrunert @giuseppe @openshift-merge-robot