Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.22] server: notify user when network is not ready yet #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 17, 2022
Merged

[release-1.22] server: notify user when network is not ready yet #5507

openshift-merge-robot merged 2 commits into from
Feb 17, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 15, 2021

This is an automated cherry-pick of #5284

/assign haircommander

fix a bug where CRI-O would never shutdown if the networking plugin wasn't configured correctly

@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 15, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2021
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 15, 2021
@openshift-ci openshift-ci bot requested review from giuseppe and kolyshkin December 15, 2021 02:19
@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #5507 (0b7104f) into release-1.22 (3c9732a) will decrease coverage by 0.01%.
The diff coverage is 12.50%.

@@               Coverage Diff                @@
##           release-1.22    #5507      +/-   ##
================================================
- Coverage         43.78%   43.77%   -0.02%     
================================================
  Files               120      120              
  Lines             11837    11843       +6     
================================================
+ Hits               5183     5184       +1     
- Misses             6163     6168       +5     
  Partials            491      491

@saschagrunert
Copy link
Member

saschagrunert commented Dec 15, 2021

@haircommander do we have a BZ here, too?

@haircommander
Copy link
Member

haircommander commented Dec 15, 2021

@haircommander do we have a BZ here, too?

No, and I'm not sure we need one. this fix is more of a nice to have for end-users, not necessarily fixing a bug openshift should encounter

@haircommander
server: notify user when network isn't ready yet
e36faae 
or else they just wait forever

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
cni manager: catch server shutdown
0b7104f 
or else CRI-O will never stop if the network isn't up

Signed-off-by: Peter Hunt <[email protected]>
@haircommander haircommander force-pushed the cherry-pick-5284-to-release-1.22 branch from 9f56ea2 to 0b7104f Compare February 10, 2022 18:46
@haircommander
Copy link
Member

haircommander commented Feb 10, 2022

/retest-required

@haircommander
Copy link
Member

haircommander commented Feb 17, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@haircommander
Copy link
Member

haircommander commented Feb 17, 2022

/retest-required

@openshift-bot
Copy link

openshift-bot commented Feb 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Feb 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Feb 17, 2022

/override ci/openshift-jenkins/integration_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Feb 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 0b7104f link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 0b7104f link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Feb 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ab89fa1 into cri-o:release-1.22 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @saschagrunert @haircommander @openshift-bot @openshift-merge-robot