Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: reduce object creation in List{Containers,PodSandboxes} #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Jul 2, 2022
Merged

server: reduce object creation in List{Containers,PodSandboxes} #5672

openshift-ci merged 1 commit into from
Jul 2, 2022
+28 −23

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Feb 22, 2022

by only creating a new sandbox or container object when they change

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 22, 2022
@openshift-ci openshift-ci bot requested review from fgiudici and wgahnagl February 22, 2022 16:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@haircommander haircommander force-pushed the list-fewer-copy branch 2 times, most recently from 88ce689 to 01f2c19 Compare February 22, 2022 16:51
@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #5672 (347b47f) into main (77718dc) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

❗ Current head 347b47f differs from pull request most recent head efff387. Consider uploading reports for the commit efff387 to get more accurate results

@@            Coverage Diff             @@
##             main    #5672      +/-   ##
==========================================
- Coverage   43.36%   42.97%   -0.40%     
==========================================
  Files         123      123              
  Lines       12296    12299       +3     
==========================================
- Hits         5332     5285      -47     
- Misses       6450     6506      +56     
+ Partials      514      508       -6

@haircommander
Copy link
Member Author

haircommander commented Feb 22, 2022

/retest-required

@haircommander
Copy link
Member Author

haircommander commented Feb 22, 2022

related to #5606 and #5409

@haircommander
Copy link
Member Author

haircommander commented Feb 22, 2022

/retest

saschagrunert
saschagrunert approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haircommander
Copy link
Member Author

haircommander commented Feb 23, 2022

@cri-o/cri-o-maintainers PTAL

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Feb 23, 2022

LGTM
assuming happy tests

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@haircommander
Copy link
Member Author

haircommander commented May 31, 2022

@saschagrunert PTAL

saschagrunert
saschagrunert approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@saschagrunert
Copy link
Member

saschagrunert commented May 31, 2022

Oops the linter/build is not happy.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
server: reduce object creation in List{Containers,PodSandboxes}
efff387 
by only creating a new sandbox or container object when they change

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member Author

haircommander commented May 31, 2022

/hold

ci issues

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2022
@haircommander
Copy link
Member Author

haircommander commented Jul 1, 2022

/retest

@haircommander
Copy link
Member Author

haircommander commented Jul 1, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@haircommander
Copy link
Member Author

haircommander commented Jul 1, 2022

actually wait

/hold

thought of another possible problem here

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@haircommander
Copy link
Member Author

haircommander commented Jul 1, 2022

nevermind we're good
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@openshift-bot
Copy link

openshift-bot commented Jul 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander haircommander mentioned this pull request Jul 1, 2022
Closed
@openshift-bot
Copy link

openshift-bot commented Jul 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit d427c58 into cri-o:main Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@fgiudici fgiudici Awaiting requested review from fgiudici

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haircommander @TomSweeneyRedHat @saschagrunert @openshift-bot