Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.23] Fix vm containers could not restore after CRI-O restart #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 14, 2022
Merged

[release-1.23] Fix vm containers could not restore after CRI-O restart #5633

openshift-merge-robot merged 2 commits into from
Feb 14, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 14, 2022

This is an automated cherry-pick of #5574

/assign fidencio

Fix vm containers couldn't restore after cri-o restart

@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 14, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 14, 2022
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 14, 2022
@openshift-ci openshift-ci bot requested review from giuseppe and nalind February 14, 2022 09:15
@fidencio
Copy link
Contributor

fidencio commented Feb 14, 2022

/cc @fgiudici @haircommander

As we discussed in the last community meeting, I think this one would be good to have backported to stable-1.23 (at least).

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #5633 (621fa98) into release-1.23 (53ada6d) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head 621fa98 differs from pull request most recent head e19f812. Consider uploading reports for the commit e19f812 to get more accurate results

@@               Coverage Diff                @@
##           release-1.23    #5633      +/-   ##
================================================
- Coverage         43.19%   43.00%   -0.20%     
================================================
  Files               123      123              
  Lines             12220    12272      +52     
================================================
- Hits               5279     5278       -1     
- Misses             6434     6487      +53     
  Partials            507      507

@haircommander
Copy link
Member

haircommander commented Feb 14, 2022

/approve
/retest-required

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 e19f812 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 e19f812 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fgiudici
fgiudici approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @fidencio !

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@fgiudici
Copy link
Contributor

fgiudici commented Feb 14, 2022

/retest-required

@openshift-bot
Copy link

openshift-bot commented Feb 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4d85f20 into cri-o:release-1.23 Feb 14, 2022
@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
@openshift-ci openshift-ci bot mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fidencio fidencio Awaiting requested review from fidencio fidencio is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@nalind nalind Awaiting requested review from nalind

@haircommander haircommander Awaiting requested review from haircommander

1 more reviewer

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fidencio fidencio

@fgiudici fgiudici

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @fidencio @haircommander @fgiudici @openshift-bot @openshift-merge-robot @sleepymole