Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 9, 2022

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

This includes the switch to Podman v4.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Requires containers/conmon-rs#452

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 9, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub June 9, 2022 07:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@saschagrunert saschagrunert force-pushed the containers branch 5 times, most recently from 3b48209 to 76d1e1e Compare June 9, 2022 08:32
@saschagrunert
Copy link
Member Author

/test e2e-gcp

@saschagrunert
Copy link
Member Author

/test e2e-agnostic

@saschagrunert
Copy link
Member Author

/hold for containers/conmon-rs#452

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@saschagrunert
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
littlejawa and others added 3 commits June 9, 2022 16:14
Updating containerd to 1.6.4.
Had to modify the way we call the Command() function from containerd:
- use of the CommandConfig structure as parameter
- use the actual binary name
  (no more converting to containerd binary naming pattern)

This later change was needed as in Containerd 1.6, the validation of the given
binary path is not done in Command() anymore - the path is used as is, allowing
custom runtime paths.
(see containerd/containerd@6870f3b1)

Signed-off-by: Julien Ropé <[email protected]>
This includes the switch to Podman v4.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

/hold

Based on top of #5956

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@saschagrunert
Copy link
Member Author

/unhold

I think this can go directly on top of main.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@saschagrunert
Copy link
Member Author

@haircommander PTAL

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member Author

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 06b6e86 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d7ded06 into cri-o:main Jun 9, 2022
@saschagrunert saschagrunert deleted the containers branch June 9, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants