-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bump containers/* dependencies
#5953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3b48209 to
76d1e1e
Compare
|
/test e2e-gcp |
|
/test e2e-agnostic |
|
/hold for containers/conmon-rs#452 |
|
/unhold |
Updating containerd to 1.6.4. Had to modify the way we call the Command() function from containerd: - use of the CommandConfig structure as parameter - use the actual binary name (no more converting to containerd binary naming pattern) This later change was needed as in Containerd 1.6, the validation of the given binary path is not done in Command() anymore - the path is used as is, allowing custom runtime paths. (see containerd/containerd@6870f3b1) Signed-off-by: Julien Ropé <[email protected]>
Signed-off-by: Julien Ropé <[email protected]>
This includes the switch to Podman v4. Signed-off-by: Sascha Grunert <[email protected]>
|
/hold Based on top of #5956 |
|
/unhold I think this can go directly on top of main. |
|
@haircommander PTAL |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
This includes the switch to Podman v4.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Requires containers/conmon-rs#452
Does this PR introduce a user-facing change?