Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.23] Bug 1977100: retry setting CPU load balancing #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 31, 2022
Merged

[release-1.23] Bug 1977100: retry setting CPU load balancing #5921

openshift-merge-robot merged 1 commit into from
May 31, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 31, 2022

This is an automated cherry-pick of #5786

/assign kolyshkin

NONE

Retry to set CPU load balancing before return the error
0db299c 
It possible that the kernel will rebuild sched_domain related files and
because of it enabling or disabling CPU load balancing for container CPUs
will fail with different file errors:

1. lstat /proc/sys/kernel/sched_domain/cpu22/domain1/flags: no such file or directory
2. readdirent /proc/sys/kernel/sched_domain/cpu66/domain0: no such file or directory

Add retry logic around setting CPU load balancing values to reduce possibility of such errors.

Signed-off-by: Artyom Lukianov <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 31, 2022
Merged
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 31, 2022
@openshift-ci openshift-ci bot requested a review from sameo May 31, 2022 18:15
@kolyshkin kolyshkin mentioned this pull request May 31, 2022
Closed
@kolyshkin
Copy link
Collaborator

kolyshkin commented May 31, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #5921 (f4e5028) into release-1.23 (41c0779) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head f4e5028 differs from pull request most recent head 0db299c. Consider uploading reports for the commit 0db299c to get more accurate results

@@               Coverage Diff                @@
##           release-1.23    #5921      +/-   ##
================================================
- Coverage         42.94%   42.91%   -0.03%     
================================================
  Files               123      123              
  Lines             12307    12315       +8     
================================================
  Hits               5285     5285              
- Misses             6515     6523       +8     
  Partials            507      507

@haircommander
Copy link
Member

haircommander commented May 31, 2022

/retest
/lgtm

thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 0db299c link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5fe1720 into cri-o:release-1.23 May 31, 2022
@openshift-ci openshift-ci bot mentioned this pull request Oct 18, 2022
Merged
@haircommander
Copy link
Member

haircommander commented Nov 8, 2022

/cherry-pick release-1.22

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 8, 2022
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 8, 2022

@haircommander: new pull request created: #6355

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@sameo sameo Awaiting requested review from sameo

Assignees

@kolyshkin kolyshkin

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @kolyshkin @haircommander @openshift-bot @openshift-merge-robot