Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update c/common to v0.53.0 #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 28, 2023
Merged

Update c/common to v0.53.0 #6843

openshift-merge-robot merged 1 commit into from
Apr 28, 2023

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 27, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

@saschagrunert
Update c/common to v0.53.0
b8d8ff1 
This fixes the umask `0` bug because it contains:
containers/common#1421

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert requested a review from mrunalp as a code owner April 27, 2023 06:45
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 27, 2023
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl April 27, 2023 06:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #6843 (b8d8ff1) into main (80a52f5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6843   +/-   ##
=======================================
  Coverage   49.71%   49.72%           
=======================================
  Files         127      127           
  Lines       14982    14982           
=======================================
+ Hits         7449     7450    +1     
+ Misses       6646     6645    -1     
  Partials      887      887

@haircommander
Copy link
Member

haircommander commented Apr 27, 2023

/lgtm
/cherry-pick release-1.27

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 27, 2023

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@sohankunkerkar
Copy link
Member

sohankunkerkar commented Apr 27, 2023

/test ci-e2e-conmonrs

@saschagrunert saschagrunert mentioned this pull request Apr 27, 2023
Closed
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 27, 2023

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Apr 27, 2023

/retest

@haircommander haircommander added this to the 1.28 milestone Apr 27, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-critest
/override ci/prow/ci-rhel-critest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration, ci/prow/ci-fedora-critest, ci/prow/ci-rhel-critest

Details

In response to this:

/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-critest
/override ci/prow/ci-rhel-critest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/override ci/prow/ci-fedora-integration
/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration, ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/ci-fedora-integration
/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 28, 2023

/override ci/prow/ci-fedora-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration

Details

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1dcce7a into cri-o:main Apr 28, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 28, 2023

@haircommander: new pull request created: #6851

Details

In response to this:

/lgtm
/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert deleted the c-common-0.53.0 branch April 28, 2023 09:39
@saschagrunert
Copy link
Member Author

saschagrunert commented May 9, 2023

/cherry-pick release-1.26

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented May 9, 2023

/cherry-pick release-1.26

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 9, 2023

@saschagrunert: cannot fork cri-o/cri-o: cannot fork cri-o/cri-o: status code 500 not one of [202], body:

Details

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented May 9, 2023

/cherry-pick release-1.26

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 9, 2023

@saschagrunert: cannot fork cri-o/cri-o: cannot fork cri-o/cri-o: status code 500 not one of [202], body:

Details

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 9, 2023

@saschagrunert: cannot fork cri-o/cri-o: cannot fork cri-o/cri-o: status code 500 not one of [202], body:

Details

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 9, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

1.28

Development

Successfully merging this pull request may close these issues.

5 participants

@saschagrunert @haircommander @openshift-cherrypick-robot @sohankunkerkar @openshift-merge-robot