Thanks to visit codestin.com
Credit goes to github.com

Skip to content

OCPBUGS-13283: [1.23] Update c/common to fix umask bug #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 23, 2023
Merged

OCPBUGS-13283: [1.23] Update c/common to fix umask bug #6902

openshift-merge-robot merged 1 commit into from
May 23, 2023

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 10, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13283

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

@saschagrunert
Update c/common to fix umask bug
d74774c 
Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels May 10, 2023
@saschagrunert saschagrunert changed the title Update c/common to fix umask bug [1.23] Update c/common to fix umask bug May 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@umohnani8
Copy link
Member

umohnani8 commented May 18, 2023

LGTM
/retest

@rphillips
Copy link
Contributor

rphillips commented May 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@rphillips
Copy link
Contributor

rphillips commented May 23, 2023

/retitle OCPBUGS-13283: [1.23] Update c/common to fix umask bug

@openshift-ci openshift-ci bot changed the title [1.23] Update c/common to fix umask bug OCPBUGS-13283: [1.23] Update c/common to fix umask bug May 23, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2023

@saschagrunert: This pull request references Jira Issue OCPBUGS-13283, which is invalid:

  • expected Jira Issue OCPBUGS-13283 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13283

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4efc71b into cri-o:release-1.23 May 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2023

@saschagrunert: Jira Issue OCPBUGS-13283: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13283 has been moved to the MODIFIED state.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13283

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert deleted the 1.23-c-common branch May 24, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saschagrunert @umohnani8 @rphillips @openshift-ci-robot @openshift-merge-robot