Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.26] Update c/common to fix umask bug #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 10, 2023
Merged

[1.26] Update c/common to fix umask bug #6895

openshift-merge-robot merged 1 commit into from
May 10, 2023

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 9, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13280

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner May 9, 2023 12:33
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 9, 2023
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl May 9, 2023 12:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@saschagrunert saschagrunert force-pushed the 1.26-c-common branch 2 times, most recently from 0234171 to 2161331 Compare May 10, 2023 06:48
@saschagrunert saschagrunert changed the title [1.26] Update c/common to v0.53.0 [1.26] Update c/common to fix umask bug May 10, 2023
@saschagrunert saschagrunert mentioned this pull request May 10, 2023
Merged
@saschagrunert saschagrunert changed the title [1.26] Update c/common to fix umask bug WIP: [1.26] Update c/common to fix umask bug May 10, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

Merging #6895 (964f114) into release-1.26 (4bcb6bf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.26    #6895   +/-   ##
=============================================
  Coverage         42.35%   42.35%           
=============================================
  Files               127      127           
  Lines             14939    14939           
=============================================
  Hits               6328     6328           
  Misses             7935     7935           
  Partials            676      676

@saschagrunert
Update c/common to fix umask bug
964f114 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert changed the title WIP: [1.26] Update c/common to fix umask bug [1.26] Update c/common to fix umask bug May 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented May 10, 2023

@cri-o/cri-o-maintainers PTAL

@sohankunkerkar
Copy link
Member

sohankunkerkar commented May 10, 2023

/test e2e-agnostic
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 200aad5 into cri-o:release-1.26 May 10, 2023
@saschagrunert saschagrunert deleted the 1.26-c-common branch May 11, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@sohankunkerkar sohankunkerkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @sohankunkerkar @openshift-merge-robot