Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 10, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13281

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 10, 2023
@saschagrunert saschagrunert changed the title Update c/common to fix umask bug [1.24] Update c/common to fix umask bug May 10, 2023
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 10, 2023
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl May 10, 2023 13:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #6901 (ebd7766) into release-1.24 (b007cb6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.24    #6901      +/-   ##
================================================
- Coverage         42.89%   42.88%   -0.01%     
================================================
  Files               124      124              
  Lines             12749    12749              
================================================
- Hits               5469     5468       -1     
- Misses             6754     6755       +1     
  Partials            526      526              

@umohnani8
Copy link
Member

LGTM
/retest

@saschagrunert
Copy link
Member Author

@cri-o/ocicni-maintainers PTAL, 4.12/1.25 got verified

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants