Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cri: implement RuntimeConfig rpc #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jul 24, 2023
Merged

cri: implement RuntimeConfig rpc #7079

openshift-merge-robot merged 2 commits into from
Jul 24, 2023

Conversation

@marquiz
Copy link
Contributor

@marquiz marquiz commented Jun 22, 2023 •
edited
Loading

What type of PR is this?

/kind feature
/kind dependency-change

What this PR does / why we need it:

This PR iimplements the new RuntimeConfig rpc of the CRI API, also implementing the CRI server side of Kubernetes KEP-4033.

The PR also contains the required vendor/dependencies update of Kubernetes to v1.28.0-beta.0 to bump cri-api to include the new rpc.

Which issue(s) this PR fixes:

None

Refs kubernetes/kubernetes#118770
Refs https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Not in cri-o, but Kubernetes users will see a change (not sure if we want to capture it here).

WIP: The user of Kubernetes v1.28 or later can omit the configuration of the kubelet cgroupDriver option if the Kubernetes KubeletCgroupDriverFromCRI feature flag in kubelet has been enabled.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

Hi @marquiz. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Jun 22, 2023

/cc @haircommander

@openshift-ci openshift-ci bot requested a review from haircommander June 22, 2023 14:23
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #7079 (6f385ea) into main (ef31a32) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 6f385ea differs from pull request most recent head ecd7f9a. Consider uploading reports for the commit ecd7f9a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7079      +/-   ##
==========================================
- Coverage   49.16%   49.12%   -0.04%     
==========================================
  Files         135      136       +1     
  Lines       15486    15496      +10     
==========================================
- Hits         7613     7612       -1     
- Misses       6971     6982      +11     
  Partials      902      902

@marquiz marquiz force-pushed the devel/cgroup-driver-autoconfig branch from 4da8dee to 009efd2 Compare June 22, 2023 14:49
@haircommander haircommander added this to the 1.28 milestone Jul 3, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2023
@sohankunkerkar sohankunkerkar mentioned this pull request Jul 18, 2023
Closed
@marquiz marquiz force-pushed the devel/cgroup-driver-autoconfig branch from 009efd2 to 6f385ea Compare July 24, 2023 10:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@saschagrunert
Copy link
Member

saschagrunert commented Jul 24, 2023

/ok-to-test

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2023
@marquiz marquiz mentioned this pull request Jul 24, 2023
Closed
marquiz added 2 commits July 24, 2023 13:16
@marquiz
vendor: update Kubernetes to v1.28.0-beta.0
2463fdf 
Required to update cri-api for upcoming Kubernetes features, e.g. cgroup
driver detection.

Signed-off-by: Markus Lehtonen <[email protected]>
@marquiz
cri: implement RuntimeConfig rpc
ecd7f9a 
This patch implements the CRI server side of Kubernetes KEP-4033
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri

Signed-off-by: Markus Lehtonen <[email protected]>
@marquiz marquiz marked this pull request as ready for review July 24, 2023 10:16
@marquiz marquiz requested a review from mrunalp as a code owner July 24, 2023 10:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@marquiz marquiz force-pushed the devel/cgroup-driver-autoconfig branch from 6f385ea to ecd7f9a Compare July 24, 2023 10:16
@openshift-ci openshift-ci bot requested a review from klihub July 24, 2023 10:16
@openshift-ci openshift-ci bot requested a review from sohankunkerkar July 24, 2023 10:16
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Jul 24, 2023

Closed #7163 -> suggest to do dependency/vendor update of kubernetes in this single PR.
/kind dependency-change

@openshift-ci openshift-ci bot added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jul 24, 2023
@saschagrunert
Copy link
Member

saschagrunert commented Jul 24, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0d929ff into cri-o:main Jul 24, 2023
@marquiz marquiz deleted the devel/cgroup-driver-autoconfig branch July 24, 2023 17:34
@pacoxu pacoxu mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@haircommander haircommander Awaiting requested review from haircommander

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

1.28

Development

Successfully merging this pull request may close these issues.

4 participants

@marquiz @saschagrunert @haircommander @openshift-merge-robot