Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 24, 2023

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

Required to update cri-api for upcoming Kubernetes features, e.g. cgroup driver detection:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refs: kubernetes/enhancements#4033

Does this PR introduce a user-facing change?

None

Required to update cri-api for upcoming Kubernetes features, e.g. cgroup
driver detection:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri

Signed-off-by: Markus Lehtonen <[email protected]>
@marquiz marquiz requested a review from mrunalp as a code owner July 24, 2023 09:07
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 24, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marquiz
Once this PR has been reviewed and has the lgtm label, please assign fidencio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

Hi @marquiz. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 24, 2023

/assign @saschagrunert @haircommander

@saschagrunert
Copy link
Member

@marquiz looks like we cannot vendor it without having the CRI method in (at least)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #7163 (4d8ad59) into main (ef31a32) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7163      +/-   ##
==========================================
- Coverage   49.16%   49.15%   -0.01%     
==========================================
  Files         135      135              
  Lines       15486    15486              
==========================================
- Hits         7613     7612       -1     
- Misses       6971     6972       +1     
  Partials      902      902              

@marquiz
Copy link
Contributor Author

marquiz commented Jul 24, 2023

Fails to build without the implementation of the new CRI rpc(s) and CI fails. This PR is Included in #7079 so let's go with that without trying to split the cri-api update in a separate PR (we can re-open of so desired)
/close

@openshift-ci openshift-ci bot closed this Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

@marquiz: Closed this PR.

Details

In response to this:

Fails to build without the implementation of the new CRI rpc(s) and CI fails. This PR is Included in #7079 so let's go with that without trying to split the cri-api update in a separate PR (we can re-open of so desired)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants