-
Notifications
You must be signed in to change notification settings - Fork 1.1k
vendor: update Kubernetes to v1.28.0-beta.0 #7163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Required to update cri-api for upcoming Kubernetes features, e.g. cgroup driver detection: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri Signed-off-by: Markus Lehtonen <[email protected]>
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @marquiz. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @saschagrunert @haircommander |
|
@marquiz looks like we cannot vendor it without having the CRI method in (at least) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
- Coverage 49.16% 49.15% -0.01%
==========================================
Files 135 135
Lines 15486 15486
==========================================
- Hits 7613 7612 -1
- Misses 6971 6972 +1
Partials 902 902 |
|
Fails to build without the implementation of the new CRI rpc(s) and CI fails. This PR is Included in #7079 so let's go with that without trying to split the cri-api update in a separate PR (we can re-open of so desired) |
|
@marquiz: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
Required to update cri-api for upcoming Kubernetes features, e.g. cgroup driver detection:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refs: kubernetes/enhancements#4033
Does this PR introduce a user-facing change?