-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.28] kata: support confidential container's api for pulling image in the guest #7678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.28] kata: support confidential container's api for pulling image in the guest #7678
Conversation
…uest For confidential container, we want to have the ability to pull the image on the guest side, and not rely on the host's repository. To achieve this, an extension to the kata shim's options for CreateContainer was added. Provided the right information through these options, the kata agent in the remote VM will proceed with the PullImage before handling the actual CreateContainer. This commit adds support for this method. Signed-off-by: Julien Ropé <[email protected]>
|
/cc @haircommander |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #7678 +/- ##
================================================
- Coverage 48.66% 48.55% -0.11%
================================================
Files 136 136
Lines 15832 15864 +32
================================================
- Hits 7704 7703 -1
- Misses 7219 7252 +33
Partials 909 909 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, littlejawa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
The failing tests are in oom, which I think is flaky ? I'm not sure how to retest though - the command doesn't seem to have the effect I thought :-/ Others (shellcheck and shfmt) are not related to this PR - they pre-exist in release-1.28 and main. |
This is a backport of PR #7471