Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@littlejawa
Copy link
Contributor

@littlejawa littlejawa commented Jan 10, 2024

This is a backport of PR #7471

Confidential Containers: add support for pull-in-guest method

…uest

For confidential container, we want to have the ability to pull the image
on the guest side, and not rely on the host's repository.

To achieve this, an extension to the kata shim's options for CreateContainer
was added. Provided the right information through these options,
the kata agent in the remote VM will proceed with the PullImage before
handling the actual CreateContainer.

This commit adds support for this method.

Signed-off-by: Julien Ropé <[email protected]>
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 10, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl January 10, 2024 15:19
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 10, 2024
@littlejawa
Copy link
Contributor Author

/cc @haircommander

@openshift-ci openshift-ci bot requested a review from haircommander January 10, 2024 15:20
@codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #7678 (47a02f7) into release-1.28 (06cf7f6) will decrease coverage by 0.11%.
Report is 5 commits behind head on release-1.28.
The diff coverage is 0.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #7678      +/-   ##
================================================
- Coverage         48.66%   48.55%   -0.11%     
================================================
  Files               136      136              
  Lines             15832    15864      +32     
================================================
- Hits               7704     7703       -1     
- Misses             7219     7252      +33     
  Partials            909      909              

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, littlejawa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@littlejawa
Copy link
Contributor Author

/retest

1 similar comment
@littlejawa
Copy link
Contributor Author

/retest

@littlejawa
Copy link
Contributor Author

The failing tests are in oom, which I think is flaky ? I'm not sure how to retest though - the command doesn't seem to have the effect I thought :-/

Others (shellcheck and shfmt) are not related to this PR - they pre-exist in release-1.28 and main.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7842da9 into cri-o:release-1.28 Jan 17, 2024
@littlejawa littlejawa deleted the backport_coco_pull_imge_support branch January 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants