Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Sunnatillo
Copy link

Uplifts go version to 1.24.6

@Sunnatillo Sunnatillo requested a review from mrunalp as a code owner August 28, 2025 13:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 28, 2025
@openshift-ci openshift-ci bot requested review from bitoku and littlejawa August 28, 2025 13:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

Hi @Sunnatillo. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2025
@bitoku
Copy link
Contributor

bitoku commented Aug 28, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2025
@Sunnatillo
Copy link
Author

I am bit lost to use nix packages which container go v1.24.6. I would really appreciate if someone points how to fix following error:
go: go.mod requires go >= 1.24.6 (running go 1.24.5; GOTOOLCHAIN=local)

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.03%. Comparing base (d79c6c6) to head (43efb3a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9429      +/-   ##
==========================================
- Coverage   67.15%   67.03%   -0.13%     
==========================================
  Files         202      202              
  Lines       27900    27900              
==========================================
- Hits        18737    18703      -34     
- Misses       7594     7625      +31     
- Partials     1569     1572       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku
Copy link
Contributor

bitoku commented Aug 28, 2025

@Sunnatillo It might be fixed by this PR #9434 or we might have to wait for the nix upstream to have the go version

This was referenced Aug 28, 2025
@Sunnatillo
Copy link
Author

/retest

@Sunnatillo Sunnatillo force-pushed the bump-go-version/sunnat branch from 5ad927b to 43efb3a Compare August 29, 2025 11:07
@Sunnatillo
Copy link
Author

Sunnatillo commented Aug 29, 2025

@Sunnatillo It might be fixed by this PR #9434 or we might have to wait for the nix upstream to have the go version

Will the changes related to uplift of nixpkgs be backported to release branches, specifically release 1.33?
AFAIU nixpkgs is used to build artifacts for releases as well. Will next patch release of 1.33 build against latest nixpkgs config?

@bitoku
Copy link
Contributor

bitoku commented Aug 29, 2025

@Sunnatillo I don't think so. We need to backport the nixpkg too.

@Sunnatillo Sunnatillo closed this Sep 1, 2025
@Sunnatillo Sunnatillo force-pushed the bump-go-version/sunnat branch from 43efb3a to 5faaf01 Compare September 1, 2025 06:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Author

it went in as a part of #9437

@Sunnatillo
Copy link
Author

Sunnatillo commented Sep 1, 2025

@Sunnatillo I don't think so. We need to backport the nixpkg too.

Is it ok if I open PR nixpkgs uplift for release-1.33 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants