-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bump go version to 1.24.6 #9429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Sunnatillo. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
I am bit lost to use nix packages which container go v1.24.6. I would really appreciate if someone points how to fix following error: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9429 +/- ##
==========================================
- Coverage 67.15% 67.03% -0.13%
==========================================
Files 202 202
Lines 27900 27900
==========================================
- Hits 18737 18703 -34
- Misses 7594 7625 +31
- Partials 1569 1572 +3 🚀 New features to boost your workflow:
|
|
@Sunnatillo It might be fixed by this PR #9434 or we might have to wait for the nix upstream to have the go version |
|
/retest |
5ad927b to
43efb3a
Compare
Will the changes related to uplift of nixpkgs be backported to release branches, specifically release 1.33? |
|
@Sunnatillo I don't think so. We need to backport the nixpkg too. |
43efb3a to
5faaf01
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sunnatillo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
it went in as a part of #9437 |
Is it ok if I open PR nixpkgs uplift for release-1.33 branch? |
Uplifts go version to 1.24.6