apps/web/lib/partners/create-partner-commission.ts (1)

158-174: ⚠️ Potential issue

Ensure currency is always populated

currency is passed to Prisma regardless of event type.
When called from the custom-commission path it is undefined, leading to a DB error if the column is NOT NULL.

-        currency,
+        currency: currency ?? "usd",

Consider making the parameter required or defaulting earlier to avoid silent failures.

apps/web/app/(ee)/api/paypal/webhook/verify-signature.ts (1)

37-39: Use structured logging rather than plain console.error

While re-formatting is harmless, relying on console.* makes log aggregation harder in prod. Prefer your central logger (e.g., logger.error({ msg: "...", headers })) so JSON output is preserved.

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-button.tsx (1)

9-9: nested: false is the default – can be omitted

Unless you intend to emphasise the explicit choice, dropping nested: false reduces noise.

-    useCreateCommissionSheet({
-      nested: false,
-      partnerId: "",
-    });
+    useCreateCommissionSheet({ partnerId });

apps/web/ui/partners/partner-details-sheet.tsx (1)

21-21: Use the existing alias for app-layer imports

All other internal paths use the @/ alias while this line relies on "app/app.dub.co/…".
Prefer a single convention (@/...) or add a proper TS path alias; otherwise the build may break outside the Next-js app dir.

apps/web/lib/actions/partners/create-commission.ts (1)

39-52: Skip unnecessary DB queries for custom commissions

The partner/customer fetch happens even when linkId is absent and you immediately return in the next block.
Moving the custom-commission guard before this Promise.all will avoid an extra network/database round-trip.

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-sheet.tsx (1)

145-147: Avoid floating-point rounding errors when scaling currency

data.amount * 100 and data.saleAmount * 100 can introduce precision issues (19.99 * 100 → 1998.999…).
Use Math.round(Number(value) * 100) or a decimal library.

- amount: data.amount ? data.amount * 100 : null,
+ amount: data.amount ? Math.round(data.amount * 100) : null,
- saleAmount: data.saleAmount ? data.saleAmount * 100 : null,
+ saleAmount: data.saleAmount ? Math.round(data.saleAmount * 100) : null,

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-sheet.tsx (1)

131-146: Minor: variable shadowing reduces clarity

const date = … inside onSubmit shadows the earlier date obtained from watch.
While harmless, using distinct identifiers (e.g. isoDate) avoids cognitive overhead.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-sheet.tsx (1)

125-146: ⚠️ Potential issue

Monetary conversion can lose cents & hides a shadowed variable

1. data.amount * 100 (and same for saleAmount) produces floating-point rounding errors (0.1 * 100 → 10.0000000001).
2. The local constant date shadows the watched date, which is confusing.

-const date = data.date ? new Date(data.date).toISOString() : null;
+const isoDate = data.date ? new Date(data.date).toISOString() : null;

-amount: data.amount ? data.amount * 100 : null,
-saleAmount: data.saleAmount ? data.saleAmount * 100 : null,
+amount: data.amount != null ? Math.round(data.amount * 100) : null,
+saleAmount: data.saleAmount != null ? Math.round(data.saleAmount * 100) : null,

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-sheet.tsx (4)

156-174: ⚠️ Potential issue

Submit guard still omits saleEventDate & customerId
Issue was raised previously and remains unfixed.

The button allows:
• a sale without a saleEventDate
• a lead without a customerId

Please incorporate the missing checks as already suggested.

---

394-435: ⚠️ Potential issue

Switch for “custom lead event date” is inside a zero-height container

When hasCustomLeadEventDate is false the container height is 0 px, so the switch is invisible and cannot be toggled—user is locked out of the feature.

Move the <Switch> outside the collapsing <AnimatedSizeContainer> and keep only the picker inside.

---

438-480: ⚠️ Potential issue

Same invisibility problem for “custom lead event name”

The pattern repeats: switch is hidden together with the inputs it controls.

Restructure as above.

---

556-610: ⚠️ Potential issue

Invoice-ID toggle unreachable

<AnimatedSizeContainer> is hidden (display:none) until hasInvoiceId is true, yet the <Switch> that could flip that flag sits inside the same container. Users can never activate it.

Expose the switch outside the collapsible block.

apps/web/styles/globals.css (1)

25-32: Add Firefox-friendly rule to fully suppress number spinners

-moz-appearance is deprecated and ignored in modern Firefox.
Add the standards-track appearance: textfield; for Gecko to guarantee the spinner never flashes on focus.

 input[type="number"]::-webkit-inner-spin-button,
 input[type="number"]::-webkit-outer-spin-button {
   -webkit-appearance: none;
-  -moz-appearance: none;
-  appearance: none;
+  appearance: none; /* Chromium / WebKit */
+}
+
+input[type="number"] {
+  appearance: textfield; /* Firefox */
   margin: 0;
 }

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/create-commission-sheet.tsx (2)

101-111: Effect overwrites user accordion choices every render

setOpenAccordions runs on every commissionType change and hard-codes the open panels, so a user who manually collapses a section will have it re-opened on the next keystroke.
Persist user state or update once (e.g. inside initial useEffect).

-  useEffect(() => {
-    const baseValues = ["partner-and-type"];
-    if (commissionType === "custom") {
-      setOpenAccordions([...baseValues, "commission"]);
-    } else if (commissionType === "sale") {
-      setOpenAccordions([...baseValues, "customer", "sale"]);
-    } else if (commissionType === "lead") {
-      setOpenAccordions([...baseValues, "customer"]);
-    }
-  }, [commissionType]);
+  // Initialise once; afterwards let the accordion manage itself
+  useEffect(() => {
+    setOpenAccordions((prev) =>
+      prev.length ? prev : ["partner-and-type", commissionType === "custom" ? "commission" : "customer"],
+    );
+  }, []); /* ← empty dep array */

---

527-547: Consistent money input UX

saleAmount input lacks onKeyDown={handleMoneyKeyDown} while the amount field has it. Add it for uniform validation and to prevent “e+” scientific notation entry.

-  <input
+  <input
     {...field}
     type="number"
+    onKeyDown={handleMoneyKeyDown}
     …
   />

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro