apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts (1)

367-371: Harden background task with error logging (keep fire-and-forget semantics).

Wrap the workflow call in .catch to avoid unhandled rejections and to log context.

-      waitUntil(
-        executeWorkflows({
-          trigger: WorkflowTrigger.saleRecorded,
-          programId: link.programId,
-          partnerId: link.partnerId,
-        }),
-      );
+      waitUntil(
+        executeWorkflows({
+          trigger: WorkflowTrigger.saleRecorded,
+          programId: link.programId,
+          partnerId: link.partnerId,
+        }).catch((err) =>
+          console.error("[executeWorkflows] saleRecorded failed", {
+            err,
+            programId: link.programId,
+            partnerId: link.partnerId,
+          }),
+        ),
+      );

Also confirm createPartnerCommission is idempotent so workflows aren’t triggered twice on duplicate Stripe events.

apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts (1)

214-219: Add .catch on background workflow execution.

Same rationale as the checkout handler—log but don’t fail the request.

-      waitUntil(
-        executeWorkflows({
-          trigger: WorkflowTrigger.saleRecorded,
-          programId: link.programId,
-          partnerId: link.partnerId,
-        }),
-      );
+      waitUntil(
+        executeWorkflows({
+          trigger: WorkflowTrigger.saleRecorded,
+          programId: link.programId,
+          partnerId: link.partnerId,
+        }).catch((err) =>
+          console.error("[executeWorkflows] saleRecorded failed", {
+            err,
+            programId: link.programId,
+            partnerId: link.partnerId,
+          }),
+        ),
+      );

packages/email/src/templates/new-commission-alert-partner.tsx (1)

92-96: Fix invalid Tailwind class; optionally use component.

Use font-semibold (not text-semibold) and drop the conflicting font-medium.

-                    <a
-                      href={shortLink}
-                      className="text-semibold font-medium text-black underline"
-                    >
+                    <a
+                      href={shortLink}
+                      className="font-semibold text-black underline"
+                    >

Optionally:

-                    <a
+                    <Link
                       href={shortLink}
-                      className="font-semibold text-black underline"
+                      className="font-semibold text-black underline"
                     >
                       {getPrettyUrl(shortLink)}
-                    </a>
+                    </Link>

apps/web/lib/api/partners/notify-partner-commission.ts (3)

124-126: Handle missing partner name in owner email subject.

Avoid “New commission for null”.

-          subject: `New commission for ${partner.name}`,
+          subject: `New commission${partner.name ? ` for ${partner.name}` : ""}`,

---

141-144: Fail fast when email client isn’t configured.

resend?.batch.send(...) silently no-ops if resend is undefined, making issues hard to detect.

-  await Promise.all(
-    emailChunks.map((emailChunk) => resend?.batch.send(emailChunk)),
-  );
+  if (!resend) {
+    console.warn("[notifyPartnerCommission] Resend client not configured; skipping email send.");
+    return;
+  }
+  await Promise.all(emailChunks.map((emailChunk) => resend.batch.send(emailChunk)));

---

68-79: Drop unnecessary Promise.resolve wrappers.

Simplifies readability without changing behavior.

-    commission.linkId
-      ? Promise.resolve(
-          prisma.link.findUnique({
-            where: {
-              id: commission.linkId,
-            },
-            select: {
-              shortLink: true,
-            },
-          }),
-        )
-      : Promise.resolve(null),
+    commission.linkId
+      ? prisma.link.findUnique({
+          where: { id: commission.linkId },
+          select: { shortLink: true },
+        })
+      : null,

apps/web/lib/partners/create-partner-commission.ts (1)

243-262: Good to fetch program+workspace in waitUntil; minor select tightening.

Nice placement off the request path. You can drop id from the program select since it's unused here to shave payload a bit.

I’m also leveraging the prior learning that each workspace has exactly one program—fetching by programId and destructuring workspace is consistent with that rule.

           select: {
-            id: true,
             name: true,
             slug: true,
             logo: true,
             holdingPeriodDays: true,
             workspace: {
               select: {
                 id: true,
                 slug: true,
                 name: true,
                 webhookEnabled: true,
               },
             },
           },

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: devkiran
PR: dubinc/dub#2736
File: apps/web/lib/api/get-workspace-users.ts:76-83
Timestamp: 2025-08-25T17:42:13.600Z
Learning: Business rule confirmed: Each workspace has exactly one program. The code should always return workspace.programs[0] since there's only one program per workspace.

Learnt from: devkiran
PR: dubinc/dub#2510
File: apps/web/lib/actions/partners/onboard-program.ts:16-19
Timestamp: 2025-06-10T19:16:23.445Z
Learning: Business rule: Each workspace may have at most one program; attempting to create more must be blocked in code.

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

packages/email/src/templates/new-commission-alert-partner.tsx (1)

53-57: Stray “$” in Preview copy has been fixed.

No more dangling character; preview reads correctly.

apps/web/lib/api/partners/notify-partner-commission.ts (1)

81-84: Gate zero/negative earnings to avoid misleading emails.

Clawbacks/adjustments (earnings <= 0) currently send “You just made a commission…”. Skip or route to a dedicated template.

   if (!partner) {
     return;
   }
+
+  // Skip misleading notifications for clawbacks/zero-earnings.
+  if (commission.earnings <= 0) {
+    // TODO: consider a dedicated "commission adjusted/clawback" notification.
+    return;
+  }

apps/web/lib/partners/create-partner-commission.ts (1)

266-268: Don’t email partners for clawbacks/fraud/canceled or zero/negative earnings.

This was already raised; notifyPartnerCommission is still unconditional here. Gate it to avoid misleading “you earned a commission” emails.

Apply:

         const isClawback = earnings < 0;
         const shouldTriggerWorkflow = !isClawback && !skipWorkflow;
+        const shouldNotify =
+          !isClawback &&
+          commission.earnings > 0 &&
+          commission.status !== "fraud" &&
+          commission.status !== "canceled";
@@
-          notifyPartnerCommission({
-            program,
-            workspace,
-            commission,
-          }),
+          ...(shouldNotify
+            ? [
+                notifyPartnerCommission({
+                  program,
+                  workspace,
+                  commission,
+                }),
+              ]
+            : []),

Alternative: enforce this centrally inside notifyPartnerCommission with an early return on disallowed statuses or non-positive earnings.

Also applies to: 289-294

packages/email/src/templates/welcome-email-partner.tsx (1)

39-40: Copy tweak looks good.

Shorter line reads cleanly. If you prefer a slightly warmer tone, consider “It’s time to start earning…”.

packages/email/src/templates/new-sale-alert-program-owner.tsx (1)

69-75: Verify currency duplication with currencyFormatter.

If currencyFormatter already includes “$”, appending “USD” in the rows below results in “$X.XX USD”. Confirm intended style; otherwise drop the “ USD” suffix for consistency.

packages/email/src/templates/new-commission-alert-partner.tsx (1)

89-98: Use and remove invalid Tailwind class.

Replace the raw with the react-email for consistency, and drop “text-semibold” (not a valid Tailwind class).

-                    <a
-                      href={shortLink}
-                      className="text-semibold font-medium text-black underline"
-                    >
-                      {getPrettyUrl(shortLink)}
-                    </a>
+                    <Link
+                      href={shortLink}
+                      className="font-medium text-black underline"
+                    >
+                      {getPrettyUrl(shortLink)}
+                    </Link>

apps/web/lib/api/partners/notify-partner-commission.ts (5)

67-79: Simplify optional link fetch; avoid redundant Promise.resolve.

Promise.resolve around an existing promise is unnecessary. This also reads cleaner:

-    commission.linkId
-      ? Promise.resolve(
-          prisma.link.findUnique({
-            where: {
-              id: commission.linkId,
-            },
-            select: {
-              shortLink: true,
-            },
-          }),
-        )
-      : Promise.resolve(null),
+    commission.linkId
+      ? prisma.link.findUnique({
+          where: { id: commission.linkId },
+          select: { shortLink: true },
+        })
+      : null,

---

105-108: Deduplicate partner recipient emails.

Guard against duplicate addresses if multiple user records map to the same email.

-  const partnerEmailsToNotify = partner.users
-    .map(({ user }) => user.email)
-    .filter(Boolean) as string[];
+  const partnerEmailsToNotify = Array.from(
+    new Set(
+      (partner.users.map(({ user }) => user.email).filter(Boolean) as string[]) ||
+        [],
+    ),
+  );

---

111-120: Pass only required props to NewCommissionAlertPartner.

Avoid spreading unused fields (partner) into the template props.

-    ...partnerEmailsToNotify.map((email) => ({
+    ...partnerEmailsToNotify.map((email) => ({
       subject: "You just made a commission via Dub Partners!",
       from: VARIANT_TO_FROM_MAP.notifications,
       to: email,
-      react: NewCommissionAlertPartner({
-        email,
-        ...data,
-      }),
+      react: NewCommissionAlertPartner({
+        email,
+        program: data.program,
+        commission: data.commission,
+        shortLink: data.shortLink,
+      }),
     })),

---

122-126: Align owner email subject with body copy.

Body/preview says “You received a sale…”, but subject says “New commission…”. Consider a sale-focused subject for clarity when type === "sale".

-          subject: `New commission for ${partner.name}`,
+          subject: `New sale referred by ${partner.name}`,

---

142-144: Optional: add basic error logging around batch sends.

Helps diagnose delivery issues without failing the whole promise chain.

-  await Promise.all(
-    emailChunks.map((emailChunk) => resend?.batch.send(emailChunk)),
-  );
+  await Promise.all(
+    emailChunks.map(async (emailChunk) => {
+      try {
+        return await resend?.batch.send(emailChunk);
+      } catch (err) {
+        console.error("[notifyPartnerCommission] resend.batch.send failed", {
+          size: emailChunk.length,
+          err,
+        });
+      }
+    }),
+  );

apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts (1)

367-371: LGTM; minor hardening for background errors.

Wrap executeWorkflows with a catch to avoid unhandled rejections inside waitUntil.

-      waitUntil(
-        executeWorkflows({
+      waitUntil(
+        executeWorkflows({
           trigger: WorkflowTrigger.saleRecorded,
           programId: link.programId,
           partnerId: link.partnerId,
-        }),
+        }).catch(console.error),
       );

apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts (1)

214-218: LGTM; mirror the small error guard.

Same optional catch as in checkout-session-completed to prevent unhandled rejections inside waitUntil.

-        executeWorkflows({
+        executeWorkflows({
           trigger: WorkflowTrigger.saleRecorded,
           programId: link.programId,
           partnerId: link.partnerId,
-        }),
+        }).catch(console.error),

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: devkiran
PR: dubinc/dub#2736
File: apps/web/lib/api/get-workspace-users.ts:76-83
Timestamp: 2025-08-25T17:42:13.600Z
Learning: Business rule confirmed: Each workspace has exactly one program. The code should always return workspace.programs[0] since there's only one program per workspace.

Learnt from: devkiran
PR: dubinc/dub#2510
File: apps/web/lib/actions/partners/onboard-program.ts:16-19
Timestamp: 2025-06-10T19:16:23.445Z
Learning: Business rule: Each workspace may have at most one program; attempting to create more must be blocked in code.