apps/web/lib/zod/schemas/partners.ts (3)

106-111: OpenAPI/docs mismatch: use “totalCommissions” instead of “commissions”.

Public description should match field ids used elsewhere.

Apply:

-        "Whether to include stats fields on the partner (`clicks`, `leads`, `conversions`, `sales`, `saleAmount`, `commissions`, `netRevenue`). If false, those fields will be returned as 0.",
+        "Whether to include stats fields on the partner (`clicks`, `leads`, `conversions`, `sales`, `saleAmount`, `totalCommissions`, `netRevenue`). If false, those fields will be returned as 0.",

---

136-140: Filter/validate requested columns to avoid “undefined” CSV headers.

Unknown ids currently flow through, producing an “undefined” column header. Filter to known ids (and optionally dedupe) during parsing.

Apply:

-      columns: z
-        .string()
-        .default(exportPartnersColumnsDefault.join(","))
-        .transform((v) => v.split(",")),
+      columns: z
+        .string()
+        .default(exportPartnersColumnsDefault.join(","))
+        .transform((v) => v.split(","))
+        .transform((ids) => {
+          const allowed = new Set(exportPartnerColumns.map((c) => c.id));
+          return [...new Set(ids.filter((id) => allowed.has(id)))];
+        }),

---

79-89: Align sort key naming: use “totalCommissions” everywhere instead of “commissions”

To avoid the mismatch between the UI, Zod schema, and API mapping, please make the following mandatory refactors:

• apps/web/lib/zod/schemas/partners.ts
– Around the sortBy enum (lines ~79–89), replace "commissions" with "totalCommissions".

• apps/web/lib/api/partners/get-partners.ts
– In sortColumnsMap (around line 6), rename the key
commissions: "totalCommissions"
to
totalCommissions: "totalCommissions".
– In sortColumnExtraMap (around line 23), rename the key
commissions: "totalSaleAmount"
to
totalCommissions: "totalSaleAmount" (or adjust as needed for your desired secondary sort).

• UI consistency check
– Confirm that in program/partners/partners-table.tsx the sort‐by options array already uses "totalCommissions" (no change needed if it does).

This will ensure the Zod schema, the server‐side mapping, and the client‐side sort keys all refer to the same "totalCommissions" identifier.

apps/web/app/(ee)/api/partners/export/route.ts (1)

44-46: Sanitize and dedupe requested columns before schema/build.

Prevents unknown ids producing an “undefined” header and removes duplicates.

Apply:

-  columns = columns.sort(
+  // keep only known columns and dedupe
+  columns = [...new Set(columns.filter((id) => columnIdToLabel[id]))].sort(
     (a, b) => (columnOrderMap[a] || 999) - (columnOrderMap[b] || 999),
   );
@@
-  columns.forEach((column) => {
+  columns.forEach((column) => {
     if (expandedColumns.includes(column)) {

Note: if you adopt the Set change above, replace the includes call per that diff.

Also applies to: 48-61