apps/web/ui/modals/export-partners-modal.tsx (1)

89-95: Guard against missing email in success toast.

If session.user.email is undefined, users will see “undefined”. Add a fallback or conditionally omit the email.

-        toast.success(
-          `Your export is being processed and we'll send you an email (${session?.user?.email}) when it's ready to download.`,
-        );
+        const emailSuffix = session?.user?.email ? ` (${session.user.email})` : "";
+        toast.success(
+          `Your export is being processed and we'll email you${emailSuffix} when it's ready.`,
+        );

apps/web/app/(ee)/api/cron/partners/export/fetch-partners-batch.ts (1)

12-34: Generator logic looks solid. Consider cancellability.

Add optional AbortSignal to stop long-running exports when jobs are canceled.

-export async function* fetchPartnersBatch(
-  filters: PartnerFilters,
-  batchSize: number = 1000,
-) {
+export async function* fetchPartnersBatch(
+  filters: PartnerFilters,
+  batchSize: number = 1000,
+  signal?: AbortSignal,
+) {
   let page = 1;
   let hasMore = true;

   while (hasMore) {
+    if (signal?.aborted) break;
     const partners = await getPartners({
       ...filters,
       page,
       pageSize: batchSize,
     });

packages/email/src/templates/partner-export-ready.tsx (1)

48-57: Improve link UX for email clients.

Open in new tab and include a plaintext fallback link for clients that strip button styles.

-              <Link
-                className="rounded-lg bg-black px-6 py-3 text-center text-[12px] font-semibold text-white no-underline"
-                href={downloadUrl}
-              >
+              <Link
+                className="rounded-lg bg-black px-6 py-3 text-center text-[12px] font-semibold text-white no-underline"
+                href={downloadUrl}
+                target="_blank"
+                rel="noopener noreferrer"
+              >
                 Download Export
               </Link>
+              <Text className="mt-3 text-[12px] text-neutral-500">
+                If the button doesn’t work, copy and paste this URL into your browser: {downloadUrl}
+              </Text>

apps/web/app/(ee)/api/partners/export/route.ts (1)

106-111: Include a filename in Content-Disposition.

Improves UX when calling the route directly (without the UI blob name).

-    return new Response(convertToCSV(formattedPartners), {
+    const filename = `dub-partners-export-${new Date().toISOString()}.csv`;
+    return new Response(convertToCSV(formattedPartners), {
       headers: {
         "Content-Type": "text/csv",
-        "Content-Disposition": "attachment",
+        "Content-Disposition": `attachment; filename="${filename}"`,
       },
     });

apps/web/app/(ee)/api/partners/count/route.ts (1)

13-16: Response shape may vary; consider normalizing or typing.

getPartnersCount returns either a number or grouped rows. If clients consume this route generically, standardize the JSON shape (e.g., { total } vs { groups, groupBy }) or at least annotate the union type for clarity.

apps/web/app/(ee)/api/cron/partners/export/route.ts (3)

145-153: Set a filename in Content-Disposition.

Improve download UX and avoid generic names.

-      headers: {
-        "Content-Type": "text/csv",
-        "Content-Disposition": "attachment",
-      },
+      headers: {
+        "Content-Type": "text/csv",
+        // Example: partners-2025-10-27.csv
+        "Content-Disposition": `attachment; filename="partners-${new Date().toISOString().slice(0,10)}.csv"`,
+      },

---

126-136: Currency/Decimal precision: avoid lossy number coercion.

Fields like totalSaleAmount/netRevenue may be Decimal/BigInt; z.coerce.number can lose precision. Prefer strings (or fixed 2‑dp formatting) for CSV.

-      if (numericColumns.includes(column)) {
-        schemaFields[columnIdToLabel[column]] = z.coerce.number().optional().default(0);
-      } else {
+      if (numericColumns.includes(column)) {
+        // Keep as string to preserve precision; format upstream if needed.
+        schemaFields[columnIdToLabel[column]] = z.string().optional().default("0");
+      } else {

And stringify Decimals when mapping:

-          let value = partner[column] || "";
+          let value = partner[column] ?? "";
+          if (numericColumns.includes(column) && value != null) {
+            value = typeof value === "object" && "toString" in value ? String(value) : String(value);
+          }

---

175-180: Defensive logging of unknown errors.

error may be non-Error. Use a safe message fallback and include context (programId, userId) when available.

-    await log({
-      message: `Error exporting partners: ${error.message}`,
+    const msg = error instanceof Error ? error.message : JSON.stringify(error);
+    await log({
+      message: `Error exporting partners: ${msg}`,
       type: "cron",
     });

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro