apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/partners/form.tsx (1)

70-79: A11y: associate label with input

Use a label with htmlFor and provide an id on the input for better accessibility.

-            <span className="mb-1.5 block text-sm font-medium text-neutral-800">
-              Email
-            </span>
+            <label
+              htmlFor={`partner-email-${index}`}
+              className="mb-1.5 block text-sm font-medium text-neutral-800"
+            >
+              Email
+            </label>
...
-              <Input
+              <Input
+                id={`partner-email-${index}`}
                 {...register(`partners.${index}.email`)}
                 type="email"
                 placeholder="[email protected]"

apps/web/lib/actions/partners/create-program.ts (1)

58-60: Pre-generating IDs inside the txn is fine, but consider moving ID gen outside.

Generating programId early enables deterministic logo paths—nice. However, you can move ID generation (and the logo upload) outside the Prisma transaction to avoid holding the DB transaction open during network I/O.

Apply this diff to drop in-txn ID gen:

-    const programId = createId({ prefix: "prog_" });
-    const defaultGroupId = createId({ prefix: "grp_" });

Then, above prisma.$transaction(...), precompute IDs and (optionally) upload the logo:

// before prisma.$transaction
const programId = createId({ prefix: "prog_" });
const defaultGroupId = createId({ prefix: "grp_" });
const logoUrl =
  uploadedLogo
    ? (await storage
        .upload(`programs/${programId}/logo_${nanoid(7)}`, uploadedLogo)
        .then(({ url }) => url))
    : null;

// inside txn: use the precomputed programId/defaultGroupId/logoUrl

If you move the upload out, consider best-effort cleanup on txn failure (e.g., try/catch around the txn and delete the uploaded key on error).

apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/rewards/form.tsx (2)

50-56: Make commission structure derived, not duplicated state.

commissionStructure is derived from maxDuration and also manually set, creating two sources of truth. Derive it directly and update only maxDuration on radio change.

Apply this diff:

-  const [commissionStructure, setCommissionStructure] = useState<
-    "one-off" | "recurring"
-  >("recurring");
-
-  useEffect(() => {
-    setCommissionStructure(maxDuration === 0 ? "one-off" : "recurring");
-  }, [maxDuration]);
+  const commissionStructure: "one-off" | "recurring" =
+    maxDuration === 0 ? "one-off" : "recurring";

And here:

-                      onChange={(e) => {
-                        if (value === "one-off") {
-                          setCommissionStructure("one-off");
-                          setValue("maxDuration", 0, { shouldValidate: true });
-                        }
-
-                        if (value === "recurring") {
-                          setCommissionStructure("recurring");
-                          setValue("maxDuration", 12, {
-                            shouldValidate: true,
-                          });
-                        }
-                      }}
+                      onChange={() => {
+                        setValue(
+                          "maxDuration",
+                          value === "one-off" ? 0 : 12,
+                          { shouldValidate: true },
+                        );
+                      }}

If you adopt this, remove the unused useEffect import.

Also applies to: 158-189

---

270-270: Use strict equality.

Prefer !== over != to avoid coercion.

-              Amount {defaultRewardType != "sale" ? "per lead" : ""}
+              Amount {defaultRewardType !== "sale" ? "per lead" : ""}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/rewards-logic.tsx:268-275
Timestamp: 2025-07-30T15:29:54.131Z
Learning: In apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward condition, dependent fields (attribute, operator, value) should be reset rather than preserved because different entities (customer vs sale) have different available attributes. Maintaining existing fields when the entity changes would create invalid state combinations and confusing UX.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

apps/web/scripts/perplexity/backfill-leads.ts (3)

1-2: Avoid blanket TypeScript suppression; prefer targeted typing fixes

// @ts-nocheck hides real bugs (see index misalignment comment below). Suggest removing it and typing the CSV parse callback instead.

Apply minimally:

-// @ts-nocheck
+
+type CSVRow = {
+  CUSTOM_USER_ID: string;
+  CAMPAIGN_NAME: string;
+  COUNTRY: string;
+  ADJUSTED_TIMESTAMP: string;
+};
@@
-  Papa.parse(fs.createReadStream("perplexity_leads.csv", "utf-8"), {
+  Papa.parse<CSVRow>(fs.createReadStream("perplexity_leads.csv", "utf-8"), {
@@
-    step: (result: {
-      data: {
-        CUSTOM_USER_ID: string;
-        CAMPAIGN_NAME: string;
-        COUNTRY: string;
-        ADJUSTED_TIMESTAMP: string;
-      };
-    }) => {
-      leadsToBackfill.push({
-        customerExternalId: result.data.CUSTOM_USER_ID,
-        partnerLinkKey: result.data.CAMPAIGN_NAME,
-        country: result.data.COUNTRY,
-        timestamp: result.data.ADJUSTED_TIMESTAMP,
-      });
-    },
+    step: ({ data }) => {
+      leadsToBackfill.push({
+        customerExternalId: data.CUSTOM_USER_ID,
+        partnerLinkKey: data.CAMPAIGN_NAME,
+        country: data.COUNTRY,
+        timestamp: data.ADJUSTED_TIMESTAMP,
+      });
+    },

---

51-58: Avoid repeated O(n) searches over partnerLinks

You do multiple .find/.some scans by key/id; build a Map for O(1) lookups.

+      const linksByLowerKey = new Map(partnerLinks.map(l => [l.key.toLowerCase(), l]));
+      const linksById = new Map(partnerLinks.map(l => [l.id, l]));
@@
-        .filter((lead) =>
-          partnerLinks.some(
-            (link) =>
-              link.key.toLowerCase() === lead.partnerLinkKey.toLowerCase(),
-          ),
-        )
+        .filter((lead) => linksByLowerKey.has(lead.partnerLinkKey.toLowerCase()))
@@
-          const link = partnerLinks.find(
-            (link) =>
-              link.key.toLowerCase() === lead.partnerLinkKey.toLowerCase(),
-          );
+          const link = linksByLowerKey.get(lead.partnerLinkKey.toLowerCase());
@@
-          const link = partnerLinks.find(
-            (link) => link.id === leadData.link_id,
-          );
+          const link = linksById.get(leadData.link_id);

Also applies to: 60-73, 112-116, 221-224

---

196-201: Externalize hard-coded IDs

project.id and reward.id literals make this script environment-specific.

-      const workspace = await prisma.project.findUniqueOrThrow({
+      const workspace = await prisma.project.findUniqueOrThrow({
         where: {
-          id: "xxx",
+          id: process.env.PROJECT_ID ?? "xxx",
         },
       });
@@
-      const leadReward = await prisma.reward.findUniqueOrThrow({
+      const leadReward = await prisma.reward.findUniqueOrThrow({
         where: {
-          id: "rw_1K1KTWJPS14SEENXFHE0FYN7J",
+          id: process.env.LEAD_REWARD_ID ?? "rw_1K1KTWJPS14SEENXFHE0FYN7J",
         },
       });

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/lib/zod/schemas/program-onboarding.ts (1)

19-24: Coerce reward amount to number (form inputs send strings)

Switch to z.coerce.number() to accept numeric strings from forms. This was flagged earlier.

 export const programRewardSchema = z.object({
   defaultRewardType: z.enum(["lead", "sale"]).default("lead"),
   type: z.nativeEnum(RewardStructure).nullish(),
-  amount: z.number().min(0).nullish(),
+  amount: z.coerce.number().min(0).nullish(),
   maxDuration: maxDurationSchema,
-});
+});

apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/partners/form.tsx (2)

39-47: Unstick the form after failed submit + add fallback error toast

Reset hasSubmitted on errors so users can retry; also guard against undefined serverError. Previously noted.

   const { executeAsync, isPending } = useAction(onboardProgramAction, {
     onSuccess: () => {
       router.push(`/${workspaceSlug}/program/new/support`);
       mutate();
     },
     onError: ({ error }) => {
-      toast.error(error.serverError);
+      setHasSubmitted(false);
+      toast.error(error.serverError ?? "We couldn’t save your invites. Please try again.");
     },
   });

---

93-106: Prevent accidental submit from "Add partner" and focus new input

Set type="button" to avoid submitting the form; focus the appended field for faster entry. Previously noted.

         <div className="mb-4">
           <Button
             text="Add partner"
             variant="secondary"
             icon={<Plus className="size-4" />}
             className="w-fit"
+            type="button"
             onClick={() => {
               if (fields.length < PROGRAM_ONBOARDING_PARTNERS_LIMIT) {
-                append({ email: "" });
+                append({ email: "" }, { shouldFocus: true });
               }
             }}
             disabled={fields.length >= PROGRAM_ONBOARDING_PARTNERS_LIMIT}
           />
         </div>

apps/web/lib/zod/schemas/program-onboarding.ts (2)

19-24: Add cross-field validation: require amount and type together

Prevents partial configurations like amount without type (or vice versa).

-export const programRewardSchema = z.object({
+export const programRewardSchema = z.object({
   defaultRewardType: z.enum(["lead", "sale"]).default("lead"),
   type: z.nativeEnum(RewardStructure).nullish(),
-  amount: z.number().min(0).nullish(),
+  amount: z.coerce.number().min(0).nullish(),
   maxDuration: maxDurationSchema,
-});
+})
+  .superRefine((val, ctx) => {
+    const hasAmount = val.amount != null;
+    const hasType = val.type != null;
+    if (hasAmount !== hasType) {
+      ctx.addIssue({
+        code: z.ZodIssueCode.custom,
+        message:
+          "When specifying a reward amount, select a reward type (and vice versa).",
+        path: hasAmount ? ["type"] : ["amount"],
+      });
+    }
+  });

---

27-33: Trim partner emails in-field to reduce false validation failures

Leading/trailing spaces cause .email() to fail; trim before validation.

-      z.object({
-        email: z.string().email("Please enter a valid email"),
-      }),
+      z.object({
+        email: z.string().trim().email("Please enter a valid email"),
+      }),

apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/partners/form.tsx (1)

108-113: Optional: show remaining invites instead of only the cap

Small UX nudge.

-        {fields.length >= PROGRAM_ONBOARDING_PARTNERS_LIMIT && (
-          <p className="text-sm text-neutral-600">
-            You can only invite up to {PROGRAM_ONBOARDING_PARTNERS_LIMIT}{" "}
-            partners.
-          </p>
-        )}
+        <p className="text-sm text-neutral-600">
+          {PROGRAM_ONBOARDING_PARTNERS_LIMIT - fields.length} of{" "}
+          {PROGRAM_ONBOARDING_PARTNERS_LIMIT} partner invites remaining.
+        </p>

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.